rename AccessToken to Secret and expand it's usage #1472
Conversation
This does 3 things: 1. Renames `AccessToken` to `Secret` 2. Prevents `Debug` of the `AccessToken` from actually showing the secret 3. Starts expanding the use of `Secret` to other areas, such as client certificates
There was a problem hiding this comment.
I'm open to this. Is there precedence in any other Azure SDKs or libraries? .NET uses Azure.Core.AccessToken.
https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/src/AccessToken.cs
|
|
||
| impl Debug for Secret { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| f.debug_tuple("Secret").field(&"<REDACTED>").finish() |
I don't know about wrapping secrets in a fashion like we've done. As it relates to your link, the AccessToken implementation used in DotNet is what we call TokenResponse, as it includes both the token and an expiration date. It's my intention to rename TokenResponse to AccessToken once this PR lands, as that should impact different places. |
This does 3 things:
AccessTokentoSecretDebugof theAccessTokenfrom actually showing the secretSecretto other areas, such as client certificates