Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Storage Blob Track2 #5896

Merged
merged 27 commits into from
Jul 2, 2019
Merged

Azure Storage Blob Track2 #5896

merged 27 commits into from
Jul 2, 2019

Conversation

annatisch
Copy link
Member

No description provided.

@adxsdk6
Copy link

adxsdk6 commented Jun 17, 2019

Can one of the admins verify this patch?

annatisch and others added 10 commits June 19, 2019 11:48
@annatisch
Storage blob track2 (#5894)
a50a17f 
* Blob storage track 2

* Started pylint fixes

* Clean pylint

* Started blob walk

* Started docstrings

* Support walk blob

* Pylint

* Refactored upload

* Pylint
@AutorestCI @annatisch
Packaging update of azure-storage-blob
48a64a2
@annatisch
Fixes to storage dependencies in CI (#5900)
ad382f3 
* Revert "Packaging update of azure-storage-blob"

This reverts commit aeeb3ce.

* Fix Storage CI

* Fixed imports

* updating ccount_key_arg -> account_key_arg

* updating ordering
@AutorestCI @annatisch
Packaging update of azure-storage-blob
8756445
@scbedd @annatisch
Revert "Packaging update of azure-storage-blob"
c35aa71 
This reverts commit 66d6877.
@scbedd @annatisch
reverting 66d6877. adding sdk_packaging.toml file
9897728
@kristapratico @annatisch
docstrings for blobs (#5954)
c2a3b1e
@annatisch
[storage-blob] Refactor shared code (#5960)
9101681 
* Fix Storage CI

* Fixed imports

* Refactor shared storage code

* Fixed XML error

* Reverted change to models

* Merged models docstrings
@annatisch
Fix setup.py version
c12750d
@annatisch
Missing recordings
28906f2
@annatisch annatisch force-pushed the azure-storage-blob-track2 branch from 5ded4ec to 28906f2 Compare June 19, 2019 19:57
xiafu-msft
xiafu-msft reviewed Jun 20, 2019
View reviewed changes
sdk/core/azure-servicemanagement-legacy/tests/legacy_mgmt_testcase.py Show resolved Hide resolved
sdk/core/azure-servicemanagement-legacy/tests/legacy_mgmt_testcase.py Show resolved Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_blob_utils.py
@@ -0,0 +1,668 @@
# -------------------------------------------------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the file name is a little bit misleading. _blob_utils is like a private thing, while, customers are expected to call down load method directly from this file, do we want to rename the file or move the content to a different place?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is internal, and wont be used by customers - I have an issue opened to refactor the contents in additional modules as needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6030

xiafu-msft
xiafu-msft reviewed Jun 21, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/authentication.py
logger = logging.getLogger(__name__)


def _encode_base64(data):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these methods in authentication.py? In _shared/encryption.py there is a line from .authentication import _encode_base64, _decode_base64_to_bytes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - good call - there's a fair amount of duplicate code in the shared module.
I will undertake a proper refactoring of this module for the next preview.
I've opened an issue here:
#6030

xiafu-msft
xiafu-msft reviewed Jun 21, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/policies.py
_LOGGER = logging.getLogger(__name__)


def encode_base64(data):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is method is totally the same as the method in authentication.py

xiafu-msft
xiafu-msft reviewed Jun 21, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/policies.py
return encoded.decode('utf-8')


def is_retry(response, mode):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this Is the duplicate of

azure-sdk-for-python/sdk/core/azure-core/azure/core/pipeline/policies/retry.py

Line 250 in 88eb9bb

def is_retry(self, settings, response):
would you like to confirm it ^_^

zezha-msft
zezha-msft reviewed Jun 21, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/blob_client.py Outdated Show resolved Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/models.py


class StorageErrorCode(str, Enum):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How were these strings gathered?

The service might change these in new service releases, so I'm wondering what's the right strategy to keep this class up to date.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are combined from the generated clients according to the swagger spec.
While that process is currently manual - we can add a CI step to validate this against the swagger spec. I will open an issue for it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6167

sdk/storage/azure-storage-blob/azure/storage/blob/_shared/policies.py


class StorageBlobSettings(object):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc string needed to explain the implications of each config

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wont document this class specifically, as it's internal.
I've opened an issue to add to the client docs all the optional configuration parameters:
#6165

sdk/storage/azure-storage-blob/azure/storage/blob/_shared/policies.py Outdated
# Block blob uploads
self.max_block_size = kwargs.get('max_block_size', 4 * 1024 * 1024)
self.min_large_block_upload_threshold = kwargs.get('min_large_block_upload_threshold', 4 * 1024 * 1024 + 1)
self.use_byte_buffer = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

especially this one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wont document this class specifically, as it's internal.
I've opened an issue to add to the client docs all the optional configuration parameters:
#6165

sdk/storage/azure-storage-blob/azure/storage/blob/_shared/policies.py Show resolved Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/policies.py Show resolved Hide resolved
zezha-msft
zezha-msft reviewed Jun 21, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/blob_service_client.py
""" A client interact with the Blob Service at the account level.

This client provides operations to retrieve and configure the account properties
as well as list, create and delete containers within the account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: I noticed that Oxford comma is not being used, I just want to confirm that this is indeed intentional and consistent across the docs.

sdk/storage/azure-storage-blob/azure/storage/blob/blob_service_client.py Outdated Show resolved Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/container_client.py Show resolved Hide resolved
annatisch added 2 commits June 27, 2019 22:08
@annatisch
[azure-storage-blob] Policy updates + simple upload/download (#6162)
1814537 
* Last blob updates

* Azure core dependency version

* Update to user-agent policy

* Review feedback
@annatisch
Merge remote-tracking branch 'origin/master' into azure-storage-blob-…
928c887 
…track2
@annatisch annatisch marked this pull request as ready for review June 28, 2019 19:21
@annatisch annatisch requested a review from lmazuel as a code owner June 28, 2019 19:21
@annatisch annatisch added the Storage Storage Service (Queues, Blobs, Files) label Jun 28, 2019
annatisch and others added 5 commits June 28, 2019 13:24
@annatisch
Removed old python tags
6cbe36f
@annatisch
Merge remote-tracking branch 'origin/master' into azure-storage-blob-…
38be077 
…track2
@kristapratico @annatisch
Code samples for blobs (#6093)
45530ba 
* adds code samples for blobs

* fixes blob code samples and adds literalincludes for docs
@kristapratico @annatisch
Storage Blobs Readme [wip] (#6011)
9418c89 
* blobs readme wip

* adding some samples and fixes for readme

* fix settings import

* moving code samples to a different PR

* small fixes to readme

* fill links for pypi and identity

* populating TODO links
@annatisch
Fix CI
63b0a9a
Rakshith Bhyravabhotla and others added 2 commits June 28, 2019 18:00
@annatisch
[Storage Blob] pylint + mypy passs (#6175)
80b5e3c 
* pylint + mypy passs

* comments
@annatisch
[storage-blob] Docs updates (#6184)
7bf5cf0 
* Docs updates

* Some docstring fixes
@zezha-msft
Copy link
Contributor

FYI I did a quick spot check for my previous concerns. Didn't have quite enough time to go into the details.

zezha-msft
zezha-msft reviewed Jul 1, 2019
View reviewed changes
sdk/eventhub/azure-eventhubs/conftest.py
from azure.eventprocessorhost.partition_manager import PartitionManager
try:
from azure.eventprocessorhost import EventProcessorHost
from azure.eventprocessorhost import EventHubPartitionPump
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the event hub checks were running, is this an intentional change for this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - because eventhubs had a dependency on a previous version of storage I added this check. We're making modifications to our CI so that EH tests can run with the correct storage version independently.

annatisch added 2 commits July 1, 2019 16:48
@annatisch
Merge remote-tracking branch 'origin/master' into azure-storage-blob-…
460226c 
…track2
@annatisch
[storage-blob] Test rename (#6197)
c95a6cb 
* Test rename

* Removed test init files

* More renames

* Try flattening tests

* Blob test imports

* Flattened queue tests

* Renamed queue test case
@annatisch annatisch merged commit c93e46e into master Jul 2, 2019
annatisch added a commit that referenced this pull request Jul 2, 2019
@annatisch
[storage-file] Docs updates (#6189)
e9341e0 
* Fix failure to parse UTF8 files with BOM (#6160)

* Fix failure to parse UTF8 files with BOM

* Match frozen requirements in cosmos

* build universal wheels (#6173)

* Batch of doc

* Typo

* Update README and HISTORY of EventHub (#6151)

* Update readme

* Update sample code, obtain connection string and documentation reference in readme

* Remove import os in readme

* Added identity snippets in readme

* Update history, readme and license

* Update history

* Update history of EventHub

* Fix wrong version

* Update history of EventHub

* Update history to be more specific

* Update install command in readme for a preview version

* Update reference documentation link in readme

* don't scan anything under doc/ (#6185)

* Docs updates

* Some docs fixes

* Expand test coverage (#6170)

* Fixed model reference

* Fixed another reference

* Azure Storage Queue Track2 (#6039)

* Initial commit for Queues (#5656)

* Initial commit

* fix build

* fix build - 2

* add version

* API buildout (#5686)

* [Storage Queues] Add autorest layer to storage queues (#5687)

* add queue.json in swagger

* Add autorest layer

* Hooking up Queue client and Queue Service Client (#5817)

* Queue client

* changes

* shared access signature

* some fixes

* add tests

* Delete settings_real.py

* Refactored shared code and added tests

* Packaging update of azure-storage-queue

* Revert "Packaging update of azure-storage-queue"

This reverts commit fdc62ab.

* Add packaging overwrite

* Fixed setup

* Fixed dependency

* Storage Queues readme (#6073)

* queues readme [wip]

* small fixes

* docstrings for queues (#6066)

* Updated user-agent policy

* Updated token test

* Updated message iterator to pageable

* Renamed dequeue to receive

* Removed Py3.4 tag

* Clean pylint

* Code samples for queues (#6088)

* adds code samples for queues

* fixes to code samples and adds literalincludes for docs

* add links for TODO

* uses unicode strings for python2 compatibility

* fix readme link

* Fix CI

* [Storage Queue] pylint  + mypy pass (#6187)

* [storage-queue] Docs updates (#6186)

* Docs updates

* First round review feedback

* Adopt MSAL 0.4.1 (#6176)

* Azure Storage Blob Track2 (#5896)

* Storage blob track2 (#5894)

* Blob storage track 2

* Started pylint fixes

* Clean pylint

* Started blob walk

* Started docstrings

* Support walk blob

* Pylint

* Refactored upload

* Pylint

* Packaging update of azure-storage-blob

* Fixes to storage dependencies in CI (#5900)

* Revert "Packaging update of azure-storage-blob"

This reverts commit aeeb3ce.

* Fix Storage CI

* Fixed imports

* updating ccount_key_arg -> account_key_arg

* updating ordering

* Packaging update of azure-storage-blob

* Revert "Packaging update of azure-storage-blob"

This reverts commit 66d6877.

* reverting 66d6877. adding sdk_packaging.toml file

* docstrings for blobs (#5954)

* [storage-blob] Refactor shared code (#5960)

* Fix Storage CI

* Fixed imports

* Refactor shared storage code

* Fixed XML error

* Reverted change to models

* Merged models docstrings

* Fix setup.py version

* Missing recordings

* Fix storage SDK conflict

* Packaging update of azure-eventhubs

* Revert "Packaging update of azure-eventhubs"

This reverts commit df844f7.

* Fix EH packaging

* Updated shared code

* Review feedback

* [azure-storage-blob] Policy updates + simple upload/download (#6162)

* Last blob updates

* Azure core dependency version

* Update to user-agent policy

* Review feedback

* Removed old python tags

* Code samples for blobs (#6093)

* adds code samples for blobs

* fixes blob code samples and adds literalincludes for docs

* Storage Blobs Readme [wip] (#6011)

* blobs readme wip

* adding some samples and fixes for readme

* fix settings import

* moving code samples to a different PR

* small fixes to readme

* fill links for pypi and identity

* populating TODO links

* Fix CI

* [Storage Blob] pylint + mypy passs (#6175)

* pylint + mypy passs

* comments

* [storage-blob] Docs updates (#6184)

* Docs updates

* Some docstring fixes

* [storage-blob] Test rename (#6197)

* Test rename

* Removed test init files

* More renames

* Try flattening tests

* Blob test imports

* Flattened queue tests

* Renamed queue test case

* Updated manifest

* Renamed testcase

* Renamed samples

* Flattened tests

* Update PyPI package links on readme Key Vault (#6194)

* Renamed recordings

* fixes sample readme links (#6198)

* [azure-storage] Missing crypto dependency (#6203)

* [azure-storage] Missing crypto dependency

* Updated queue setup with crypto

* Fixed blob nspkg dependency

* Fixed queue nspkg dependency

* Added storage nspkg to shared deps

* Fixed dependencies

* Separate settings files
annatisch added a commit that referenced this pull request Jul 3, 2019
@annatisch
Azure Storage File Track2 (#6106)
1f02e1b 
* Files Skeleton (#5921)

* Generate storage files autorest layer (#5926)

* Generate autorest layer

* oops

* Rename files to file

* [Storage Files] API skeleton with helper files (#5965)

* Hookup File Service Client (#5977)

* Hookup share client (#6000)

* commit1

* Hook up Share Client

* Directory client hookup + File client  Hookup (#6040)

* file hookup

* changes

* [storage-files]Started adding files tests (#6051)

* Updated shared module

* Added tests

* First test pass

* Fixed client tests

* Fixed service props tests

* share tests (#6084)

* random commit

* share tests

* changes

* revert to fake settings

* Updates for file client tests

* Merged clients

* Fixed tests

* Recorded tests

* Clean test pass

* Packaging update of azure-storage-file

* Fixed acl test

* Fixed copy test

* More recordings

* Fixed copy recordings

* Fixed directory test

* Added close handles

* Updated packaging

* Updated user agent policy

* Updated dependencies

* Fixed handles tests

* Fixed syntax

* Files dependency conflict

* docstrings for files (#6128)

* Storage-File readme (#6156)

* adds file readme

* fix anchor for upload file

* Removed Py3.4 tag

* Clean pylint

* Fixed generated models

* Code samples for files (#6159)

* adds code samples for files

* fixes recording

* fixes code samples and adds literalincludes for docs

* fix links for readme

* Fix CI

* [storage-file] Docs updates (#6189)

* Fix failure to parse UTF8 files with BOM (#6160)

* Fix failure to parse UTF8 files with BOM

* Match frozen requirements in cosmos

* build universal wheels (#6173)

* Batch of doc

* Typo

* Update README and HISTORY of EventHub (#6151)

* Update readme

* Update sample code, obtain connection string and documentation reference in readme

* Remove import os in readme

* Added identity snippets in readme

* Update history, readme and license

* Update history

* Update history of EventHub

* Fix wrong version

* Update history of EventHub

* Update history to be more specific

* Update install command in readme for a preview version

* Update reference documentation link in readme

* don't scan anything under doc/ (#6185)

* Docs updates

* Some docs fixes

* Expand test coverage (#6170)

* Fixed model reference

* Fixed another reference

* Azure Storage Queue Track2 (#6039)

* Initial commit for Queues (#5656)

* Initial commit

* fix build

* fix build - 2

* add version

* API buildout (#5686)

* [Storage Queues] Add autorest layer to storage queues (#5687)

* add queue.json in swagger

* Add autorest layer

* Hooking up Queue client and Queue Service Client (#5817)

* Queue client

* changes

* shared access signature

* some fixes

* add tests

* Delete settings_real.py

* Refactored shared code and added tests

* Packaging update of azure-storage-queue

* Revert "Packaging update of azure-storage-queue"

This reverts commit fdc62ab.

* Add packaging overwrite

* Fixed setup

* Fixed dependency

* Storage Queues readme (#6073)

* queues readme [wip]

* small fixes

* docstrings for queues (#6066)

* Updated user-agent policy

* Updated token test

* Updated message iterator to pageable

* Renamed dequeue to receive

* Removed Py3.4 tag

* Clean pylint

* Code samples for queues (#6088)

* adds code samples for queues

* fixes to code samples and adds literalincludes for docs

* add links for TODO

* uses unicode strings for python2 compatibility

* fix readme link

* Fix CI

* [Storage Queue] pylint  + mypy pass (#6187)

* [storage-queue] Docs updates (#6186)

* Docs updates

* First round review feedback

* Adopt MSAL 0.4.1 (#6176)

* Azure Storage Blob Track2 (#5896)

* Storage blob track2 (#5894)

* Blob storage track 2

* Started pylint fixes

* Clean pylint

* Started blob walk

* Started docstrings

* Support walk blob

* Pylint

* Refactored upload

* Pylint

* Packaging update of azure-storage-blob

* Fixes to storage dependencies in CI (#5900)

* Revert "Packaging update of azure-storage-blob"

This reverts commit aeeb3ce.

* Fix Storage CI

* Fixed imports

* updating ccount_key_arg -> account_key_arg

* updating ordering

* Packaging update of azure-storage-blob

* Revert "Packaging update of azure-storage-blob"

This reverts commit 66d6877.

* reverting 66d6877. adding sdk_packaging.toml file

* docstrings for blobs (#5954)

* [storage-blob] Refactor shared code (#5960)

* Fix Storage CI

* Fixed imports

* Refactor shared storage code

* Fixed XML error

* Reverted change to models

* Merged models docstrings

* Fix setup.py version

* Missing recordings

* Fix storage SDK conflict

* Packaging update of azure-eventhubs

* Revert "Packaging update of azure-eventhubs"

This reverts commit df844f7.

* Fix EH packaging

* Updated shared code

* Review feedback

* [azure-storage-blob] Policy updates + simple upload/download (#6162)

* Last blob updates

* Azure core dependency version

* Update to user-agent policy

* Review feedback

* Removed old python tags

* Code samples for blobs (#6093)

* adds code samples for blobs

* fixes blob code samples and adds literalincludes for docs

* Storage Blobs Readme [wip] (#6011)

* blobs readme wip

* adding some samples and fixes for readme

* fix settings import

* moving code samples to a different PR

* small fixes to readme

* fill links for pypi and identity

* populating TODO links

* Fix CI

* [Storage Blob] pylint + mypy passs (#6175)

* pylint + mypy passs

* comments

* [storage-blob] Docs updates (#6184)

* Docs updates

* Some docstring fixes

* [storage-blob] Test rename (#6197)

* Test rename

* Removed test init files

* More renames

* Try flattening tests

* Blob test imports

* Flattened queue tests

* Renamed queue test case

* Updated manifest

* Renamed testcase

* Renamed samples

* Flattened tests

* Update PyPI package links on readme Key Vault (#6194)

* Renamed recordings

* fixes sample readme links (#6198)

* [azure-storage] Missing crypto dependency (#6203)

* [azure-storage] Missing crypto dependency

* Updated queue setup with crypto

* Fixed blob nspkg dependency

* Fixed queue nspkg dependency

* Added storage nspkg to shared deps

* Fixed dependencies

* Separate settings files

* [Storage File] pylint + mypy pass (#6202)
rajivnandivada pushed a commit to rajivnandivada/azure-sdk-for-python that referenced this pull request Jul 3, 2019
@annatisch @rajivnandivada
Azure Storage Blob Track2 (Azure#5896)
d394ac8 
* Storage blob track2 (Azure#5894)

* Blob storage track 2

* Started pylint fixes

* Clean pylint

* Started blob walk

* Started docstrings

* Support walk blob

* Pylint

* Refactored upload

* Pylint

* Packaging update of azure-storage-blob

* Fixes to storage dependencies in CI (Azure#5900)

* Revert "Packaging update of azure-storage-blob"

This reverts commit aeeb3ce.

* Fix Storage CI

* Fixed imports

* updating ccount_key_arg -> account_key_arg

* updating ordering

* Packaging update of azure-storage-blob

* Revert "Packaging update of azure-storage-blob"

This reverts commit 66d6877.

* reverting 66d6877. adding sdk_packaging.toml file

* docstrings for blobs (Azure#5954)

* [storage-blob] Refactor shared code (Azure#5960)

* Fix Storage CI

* Fixed imports

* Refactor shared storage code

* Fixed XML error

* Reverted change to models

* Merged models docstrings

* Fix setup.py version

* Missing recordings

* Fix storage SDK conflict

* Packaging update of azure-eventhubs

* Revert "Packaging update of azure-eventhubs"

This reverts commit df844f7.

* Fix EH packaging

* Updated shared code

* Review feedback

* [azure-storage-blob] Policy updates + simple upload/download (Azure#6162)

* Last blob updates

* Azure core dependency version

* Update to user-agent policy

* Review feedback

* Removed old python tags

* Code samples for blobs (Azure#6093)

* adds code samples for blobs

* fixes blob code samples and adds literalincludes for docs

* Storage Blobs Readme [wip] (Azure#6011)

* blobs readme wip

* adding some samples and fixes for readme

* fix settings import

* moving code samples to a different PR

* small fixes to readme

* fill links for pypi and identity

* populating TODO links

* Fix CI

* [Storage Blob] pylint + mypy passs (Azure#6175)

* pylint + mypy passs

* comments

* [storage-blob] Docs updates (Azure#6184)

* Docs updates

* Some docstring fixes

* [storage-blob] Test rename (Azure#6197)

* Test rename

* Removed test init files

* More renames

* Try flattening tests

* Blob test imports

* Flattened queue tests

* Renamed queue test case
rajivnandivada pushed a commit to rajivnandivada/azure-sdk-for-python that referenced this pull request Jul 3, 2019
@annatisch @rajivnandivada
Azure Storage File Track2 (Azure#6106)
5b709c7 
* Files Skeleton (Azure#5921)

* Generate storage files autorest layer (Azure#5926)

* Generate autorest layer

* oops

* Rename files to file

* [Storage Files] API skeleton with helper files (Azure#5965)

* Hookup File Service Client (Azure#5977)

* Hookup share client (Azure#6000)

* commit1

* Hook up Share Client

* Directory client hookup + File client  Hookup (Azure#6040)

* file hookup

* changes

* [storage-files]Started adding files tests (Azure#6051)

* Updated shared module

* Added tests

* First test pass

* Fixed client tests

* Fixed service props tests

* share tests (Azure#6084)

* random commit

* share tests

* changes

* revert to fake settings

* Updates for file client tests

* Merged clients

* Fixed tests

* Recorded tests

* Clean test pass

* Packaging update of azure-storage-file

* Fixed acl test

* Fixed copy test

* More recordings

* Fixed copy recordings

* Fixed directory test

* Added close handles

* Updated packaging

* Updated user agent policy

* Updated dependencies

* Fixed handles tests

* Fixed syntax

* Files dependency conflict

* docstrings for files (Azure#6128)

* Storage-File readme (Azure#6156)

* adds file readme

* fix anchor for upload file

* Removed Py3.4 tag

* Clean pylint

* Fixed generated models

* Code samples for files (Azure#6159)

* adds code samples for files

* fixes recording

* fixes code samples and adds literalincludes for docs

* fix links for readme

* Fix CI

* [storage-file] Docs updates (Azure#6189)

* Fix failure to parse UTF8 files with BOM (Azure#6160)

* Fix failure to parse UTF8 files with BOM

* Match frozen requirements in cosmos

* build universal wheels (Azure#6173)

* Batch of doc

* Typo

* Update README and HISTORY of EventHub (Azure#6151)

* Update readme

* Update sample code, obtain connection string and documentation reference in readme

* Remove import os in readme

* Added identity snippets in readme

* Update history, readme and license

* Update history

* Update history of EventHub

* Fix wrong version

* Update history of EventHub

* Update history to be more specific

* Update install command in readme for a preview version

* Update reference documentation link in readme

* don't scan anything under doc/ (Azure#6185)

* Docs updates

* Some docs fixes

* Expand test coverage (Azure#6170)

* Fixed model reference

* Fixed another reference

* Azure Storage Queue Track2 (Azure#6039)

* Initial commit for Queues (Azure#5656)

* Initial commit

* fix build

* fix build - 2

* add version

* API buildout (Azure#5686)

* [Storage Queues] Add autorest layer to storage queues (Azure#5687)

* add queue.json in swagger

* Add autorest layer

* Hooking up Queue client and Queue Service Client (Azure#5817)

* Queue client

* changes

* shared access signature

* some fixes

* add tests

* Delete settings_real.py

* Refactored shared code and added tests

* Packaging update of azure-storage-queue

* Revert "Packaging update of azure-storage-queue"

This reverts commit fdc62ab.

* Add packaging overwrite

* Fixed setup

* Fixed dependency

* Storage Queues readme (Azure#6073)

* queues readme [wip]

* small fixes

* docstrings for queues (Azure#6066)

* Updated user-agent policy

* Updated token test

* Updated message iterator to pageable

* Renamed dequeue to receive

* Removed Py3.4 tag

* Clean pylint

* Code samples for queues (Azure#6088)

* adds code samples for queues

* fixes to code samples and adds literalincludes for docs

* add links for TODO

* uses unicode strings for python2 compatibility

* fix readme link

* Fix CI

* [Storage Queue] pylint  + mypy pass (Azure#6187)

* [storage-queue] Docs updates (Azure#6186)

* Docs updates

* First round review feedback

* Adopt MSAL 0.4.1 (Azure#6176)

* Azure Storage Blob Track2 (Azure#5896)

* Storage blob track2 (Azure#5894)

* Blob storage track 2

* Started pylint fixes

* Clean pylint

* Started blob walk

* Started docstrings

* Support walk blob

* Pylint

* Refactored upload

* Pylint

* Packaging update of azure-storage-blob

* Fixes to storage dependencies in CI (Azure#5900)

* Revert "Packaging update of azure-storage-blob"

This reverts commit aeeb3ce.

* Fix Storage CI

* Fixed imports

* updating ccount_key_arg -> account_key_arg

* updating ordering

* Packaging update of azure-storage-blob

* Revert "Packaging update of azure-storage-blob"

This reverts commit 66d6877.

* reverting 66d6877. adding sdk_packaging.toml file

* docstrings for blobs (Azure#5954)

* [storage-blob] Refactor shared code (Azure#5960)

* Fix Storage CI

* Fixed imports

* Refactor shared storage code

* Fixed XML error

* Reverted change to models

* Merged models docstrings

* Fix setup.py version

* Missing recordings

* Fix storage SDK conflict

* Packaging update of azure-eventhubs

* Revert "Packaging update of azure-eventhubs"

This reverts commit df844f7.

* Fix EH packaging

* Updated shared code

* Review feedback

* [azure-storage-blob] Policy updates + simple upload/download (Azure#6162)

* Last blob updates

* Azure core dependency version

* Update to user-agent policy

* Review feedback

* Removed old python tags

* Code samples for blobs (Azure#6093)

* adds code samples for blobs

* fixes blob code samples and adds literalincludes for docs

* Storage Blobs Readme [wip] (Azure#6011)

* blobs readme wip

* adding some samples and fixes for readme

* fix settings import

* moving code samples to a different PR

* small fixes to readme

* fill links for pypi and identity

* populating TODO links

* Fix CI

* [Storage Blob] pylint + mypy passs (Azure#6175)

* pylint + mypy passs

* comments

* [storage-blob] Docs updates (Azure#6184)

* Docs updates

* Some docstring fixes

* [storage-blob] Test rename (Azure#6197)

* Test rename

* Removed test init files

* More renames

* Try flattening tests

* Blob test imports

* Flattened queue tests

* Renamed queue test case

* Updated manifest

* Renamed testcase

* Renamed samples

* Flattened tests

* Update PyPI package links on readme Key Vault (Azure#6194)

* Renamed recordings

* fixes sample readme links (Azure#6198)

* [azure-storage] Missing crypto dependency (Azure#6203)

* [azure-storage] Missing crypto dependency

* Updated queue setup with crypto

* Fixed blob nspkg dependency

* Fixed queue nspkg dependency

* Added storage nspkg to shared deps

* Fixed dependencies

* Separate settings files

* [Storage File] pylint + mypy pass (Azure#6202)
@annatisch annatisch deleted the azure-storage-blob-track2 branch July 22, 2019 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiafu-msft xiafu-msft xiafu-msft left review comments

@zezha-msft zezha-msft zezha-msft approved these changes

@johanste johanste johanste left review comments

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@annatisch @adxsdk6 @zezha-msft @johanste @xiafu-msft @AutorestCI @scbedd @kristapratico