Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapping to Twine Check - Support .md in Readme #4331

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Feb 7, 2019

Example build: https://dev.azure.com/azure-sdk/playground/_build/results?buildId=4163

Also adding capability to ignore specific warnings during run_check_call in the helper scripts. However, at this time, I believe that it is valuable information to discover a test class with no tests present. (As test cases being present but unrun is a legitimate problem)

#4325
#4183

@codecov-io
Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #4331 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4331      +/-   ##
==========================================
- Coverage   53.62%   53.55%   -0.08%     
==========================================
  Files       10274    10267       -7     
  Lines      216095   215742     -353     
==========================================
- Hits       115884   115531     -353     
  Misses     100211   100211
Impacted Files Coverage Δ
...zure-servicebus/azure/servicebus/common/message.py 28.63% <0%> (-7.2%) ⬇️
azure-servicebus/conftest.py 33.1% <0%> (-4.72%) ⬇️
...ge/azure/mgmt/storage/storage_management_client.py 42.95% <0%> (-3.25%) ⬇️
...te/azure/mgmt/compute/compute_management_client.py 47.29% <0%> (-2.96%) ⬇️
...rk/azure/mgmt/network/network_management_client.py 20.49% <0%> (-2.95%) ⬇️
.../mgmt/containerservice/container_service_client.py 57.74% <0%> (-2.78%) ⬇️
...t/authorization/authorization_management_client.py 66.3% <0%> (-2.39%) ⬇️
...erregistry/container_registry_management_client.py 71.79% <0%> (-2.23%) ⬇️
...servicebus/control_client/_common_serialization.py 51.41% <0%> (-2.15%) ⬇️
...t-legacy/azure/servicemanagement/_serialization.py 81.31% <0%> (-2.02%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c53502...cbe3397. Read the comment docs.

@scbedd
Copy link
Member Author

scbedd commented Feb 7, 2019

@Azure/azure-sdk-eng

@adxsdk6
Copy link

adxsdk6 commented Feb 7, 2019

Can one of the admins verify this patch?

1 similar comment
@adxsdk6
Copy link

adxsdk6 commented Feb 7, 2019

Can one of the admins verify this patch?

.azure-pipelines/client.yml Show resolved Hide resolved
scripts/devops_tasks/common_tasks.py Outdated Show resolved Hide resolved
scripts/devops_tasks/setup_execute_tests.py Outdated Show resolved Hide resolved
@scbedd scbedd force-pushed the twinechk branch 2 times, most recently from 272121f to 2f55c9a Compare February 7, 2019 23:46
Copy link
Member

@bsiegel bsiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions

.azure-pipelines/client.yml Outdated Show resolved Hide resolved
.azure-pipelines/client.yml Outdated Show resolved Hide resolved
.azure-pipelines/client.yml Outdated Show resolved Hide resolved
* adding installation of readme-renderer[md] to resolve warning during twine check
* adding capability to ignore certain warnings coming back from utility tools
Copy link
Member

@bsiegel bsiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍✨Ship It✨:shipit:

Note: Please pull latest master and rebase this branch onto it before merging this pull request.

$ git checkout master
$ git pull origin master

$ git checkout -
$ git rebase master

$ git push -f

@scbedd scbedd merged commit 59117d6 into Azure:master Feb 8, 2019
iscai-msft pushed a commit that referenced this pull request Feb 13, 2019
* Generated from 52981377b86caf85843799cd4294ec9101af0dcf (#3777)

Make NIC VM readOnly

* [AutoPR network/resource-manager] [Portal Generated] Review request for Microsoft.Network to add version 2018-10-01 (#3718)

* Generated from 1c4c94911c840bcab2e7e7541433713f9de4a819

Updates API version in new specs and examples

* Packaging update of azure-mgmt-network

* Generated from dd13fa490b5666f900241da864fd4213652d1770 (#3776)

Make NIC VM ref readonly

* Generated from a8dc3164dab1737d09b57c3ada8c1132aaddfd66 (#3794)

change container nics property type on container nic config to resourceid

* Generated from a18fe30f1349bb8e07d0ec1f3bf977b0e70d48a0

Revert "Model ContainerNic refs under ContainerNicConfig as sub resources" (#4467)

* Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)"

This reverts commit 633d12d5b552b102f874182b8f50266eb97fdc85.

* Revert "Port fix from PR 4459 to 2018-10-01 (#4463)"

This reverts commit 5ea0c7b8bcf16d992bb1f2b5f3b52208354a4391.

* Revert "change container nics property type on container nic config to resourceid (#4459)"

This reverts commit baf31d901254dd4bf4f1813e9faeec1c9805f775.

* Generated from a34ad413b26c915dad887c853358c77b1c76ee5a (#3798)

Revert "change container nics property type on container nic config to resourceid (#4459)"

This reverts commit baf31d901254dd4bf4f1813e9faeec1c9805f775.

* Generated from f321a6cb703b15bbe927a4b34005830c495c4e34

Fixes the missing array for the header actions (#4497)

* Generated from 8f92958053478b5df8f9489654192a68a1532578

Network py 2018-10

* Generated from e58229772d0b26de18f701e416410521e358bb00

Application gateway Identity and Keyvault support (#4387)

* identity and keyvault

* Capitalization comment

* Generated from 428b52b308b52edc6e1dd617cb96ba8ee59e7b92 (#3842)

Capitalization comment

* Generated from 3749af17da52fd48f69870d8bacc577a54650ad1 (#3861)

Ported fix from master branch

* Rebuild by #3779

* 2018-10-01 as new latest

* 2.4.0

* Network 2018-10-01 test re-recordings

* Generated from b9c1d4353fbd76618c6f3f73d9d5e0b508b843e5 (#3884)

Add support for list api for global reach connections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants