Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen2download failure #38986

Merged
merged 81 commits into from
Dec 27, 2024
Merged

Conversation

achauhan-scc
Copy link
Member

@achauhan-scc achauhan-scc commented Dec 24, 2024

Description

Model download is failing if model is stored in ADLS Gen 2 datastore.
There three issues found while fixing the issue

  • container_name property was mapped to filesystem but there is no container_name returned from API.
  • API version in Gen 2 helper class, it seems like a known issue in Gen2 SDK.
  • credentials, AML only support service principal or credential less current code was not aligned with it.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@achauhan-scc achauhan-scc merged commit c694e3f into Azure:main Dec 27, 2024
21 checks passed
singankit pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants