Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Azure Entra ID only datastore auth access #38967

Merged
merged 7 commits into from
Dec 23, 2024
Merged

Fix Azure Entra ID only datastore auth access #38967

merged 7 commits into from
Dec 23, 2024

Conversation

ralph-msft
Copy link
Member

  • Fixes regression introduced when attempting to authenticate with datastores that are configured with shared key access disabled, and only accessible with Entra ID credentials (with the proper roles assigned)
  • Always retrieves time limited SAS tokens now for datastores configured with shared key access as per latest Azure security recommendations
  • Adds explicit tests for Entra ID only ("none") AI projects
  • Updates test recordings

Bug 3686546

@ralph-msft
Checkpoint:
b3bafba 
- Adds better support for "None" credentials
- Switches to different API version to enable getting expirable SAS tokens instead of the raw account keys
@ralph-msft
Simplify to only return SAS tokens, or use Entra ID
b5cde97
@ralph-msft
Add test using Entra ID credentials for uploading artifacts as well. …
23a1362 
…Update test recordings
@ralph-msft
Fix pylint warnings
707cb59
@ralph-msft ralph-msft requested a review from a team as a code owner December 20, 2024 20:48
@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Dec 20, 2024
@ralph-msft ralph-msft self-assigned this Dec 20, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@ralph-msft ralph-msft merged commit 487d0b4 into Azure:main Dec 23, 2024
27 checks passed
@ralph-msft ralph-msft deleted the ralphe/no_save_cred_bug branch December 23, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigiw luigiw luigiw approved these changes

Assignees

@ralph-msft ralph-msft

Labels
Evaluation Issues related to the client library for Azure AI Evaluation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralph-msft @azure-sdk @luigiw