Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(engsys) ci,fix: Fix Run Black falsely reporting success #38095

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

kdestin
Copy link
Member

@kdestin kdestin commented Oct 25, 2024

Description

This pull request resolves an issue where the Run Black step would falsely report success, even in situations where there were formatting violations present.

Example run against a package with known formatting violations (Note that the step attempts to resolve packages in the non-existent sdk/auto service directory)

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@kdestin kdestin requested a review from a team as a code owner October 25, 2024 05:41
@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Oct 25, 2024
@kdestin kdestin force-pushed the engsys/black/resolve-false-success branch from add0b81 to 43a38d7 Compare October 25, 2024 06:05
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@kdestin kdestin force-pushed the engsys/black/resolve-false-success branch from 43a38d7 to 0685600 Compare October 25, 2024 16:36
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the changes to validate. I think there are included changes to evaluation that you're probably deliberately checking the check with 👍

Thank you @kdestin I know what to audit across the repo for this break now.

@kdestin kdestin enabled auto-merge (squash) October 25, 2024 18:53
@kdestin kdestin merged commit 383b5cd into Azure:main Oct 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Evaluation Issues related to the client library for Azure AI Evaluation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants