Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or fix azure* environment variables in live tests #37815

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Remove or fix azure* environment variables in live tests #37815

merged 2 commits into from
Nov 14, 2024

Conversation

benbp
Copy link
Member

@benbp benbp commented Oct 9, 2024

Remove or fix azure* environment variables in live tests

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Oct 9, 2024
@benbp benbp self-assigned this Oct 9, 2024
@benbp benbp requested a review from weshaggard October 9, 2024 18:38
@benbp
Copy link
Member Author

benbp commented Oct 9, 2024

/azp run python - storage - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp benbp force-pushed the benbp/remove-hardcode-az-sub branch from 656f930 to fc7a315 Compare October 9, 2024 22:54
@benbp
Copy link
Member Author

benbp commented Oct 9, 2024

/azp run python - keyvault - tests-weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

weshaggard
weshaggard reviewed Oct 10, 2024
View reviewed changes
sdk/storage/tests.yml Outdated
@@ -31,4 +31,4 @@ extends:
EnvVars:
AZURE_SKIP_LIVE_RECORDING: 'True'
AZURE_TEST_RUN_LIVE: 'true'
AZURE_SUBSCRIPTION_ID: $(azure-subscription-id)
AZURE_SUBSCRIPTION_ID: $(STORAGE_SUBSCRIPTION_ID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this set automatically? Do we need to set it explicitly? It seems like you removed it in most other places.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AZURE prefix variables are not set automatically. I removed it in places where the test code has no reference to it (i.e. where it was only used for EnvironmentCredential in the past).

weshaggard
weshaggard reviewed Oct 10, 2024
View reviewed changes
sdk/keyvault/tests.yml Outdated Show resolved Hide resolved
@swathipil swathipil mentioned this pull request Oct 10, 2024
Merged
@benbp
Copy link
Member Author

benbp commented Oct 10, 2024

/azp run python - keyvault - tests-weekly

@benbp
Copy link
Member Author

benbp commented Oct 10, 2024

/azp run python - storage - tests-weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Oct 10, 2024

test

@benbp
Copy link
Member Author

benbp commented Oct 10, 2024

/check-enforcer evaluate

@benbp benbp mentioned this pull request Oct 28, 2024
Closed
@benbp benbp force-pushed the benbp/remove-hardcode-az-sub branch 2 times, most recently from 2291ad7 to e83a7a2 Compare November 13, 2024 20:20
@benbp benbp force-pushed the benbp/remove-hardcode-az-sub branch from e83a7a2 to 600efac Compare November 13, 2024 20:28
weshaggard
weshaggard reviewed Nov 13, 2024
View reviewed changes
eng/pipelines/templates/steps/build-test.yml Outdated
${{ insert }}: ${{ parameters.EnvVars }}
inputs:
azureSubscription: ${{ parameters.ServiceConnection }}
azureSubscription: azure-sdk-tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to retire this connection so lets prefer azure-sdk-tests-public fi these can run in TME.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are for the samples tests which in some cases still rely on static resources in the old subscription, same deal as with Java where we decided not to migrate for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought samples had their own arm templates if we were running them live. We should definitely be careful using static resources for testing samples as these are meant to be copy/pasted by customers.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@benbp benbp merged commit 333ec6a into Azure:main Nov 14, 2024
53 of 57 checks passed
@benbp benbp deleted the benbp/remove-hardcode-az-sub branch November 14, 2024 18:21
@benbp benbp mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@ChenxiJiang333 ChenxiJiang333 Awaiting requested review from ChenxiJiang333 ChenxiJiang333 is a code owner

@msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner

@kristapratico kristapratico Awaiting requested review from kristapratico kristapratico is a code owner

@quentinRobinson quentinRobinson Awaiting requested review from quentinRobinson quentinRobinson is a code owner

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner

@YalinLi0312 YalinLi0312 Awaiting requested review from YalinLi0312 YalinLi0312 is a code owner

@scbedd scbedd Awaiting requested review from scbedd scbedd is a code owner

@kashifkhan kashifkhan Awaiting requested review from kashifkhan kashifkhan is a code owner

@swathipil swathipil Awaiting requested review from swathipil swathipil is a code owner

@mccoyp mccoyp Awaiting requested review from mccoyp mccoyp is a code owner

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@jalauzon-msft jalauzon-msft Awaiting requested review from jalauzon-msft jalauzon-msft is a code owner

@vincenttran-msft vincenttran-msft Awaiting requested review from vincenttran-msft vincenttran-msft is a code owner

@weirongw23-msft weirongw23-msft Awaiting requested review from weirongw23-msft weirongw23-msft is a code owner

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner

@GrahamMThomas GrahamMThomas Awaiting requested review from GrahamMThomas GrahamMThomas is a code owner

@FlorianBorn71 FlorianBorn71 Awaiting requested review from FlorianBorn71 FlorianBorn71 is a code owner

@dubiety dubiety Awaiting requested review from dubiety dubiety is a code owner

@Lakicar95 Lakicar95 Awaiting requested review from Lakicar95 Lakicar95 is a code owner

@yogeshmo yogeshmo Awaiting requested review from yogeshmo yogeshmo is a code owner

Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbp @azure-sdk @weshaggard