-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify build yml #36567
Merged
Merged
Simplify build yml #36567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
requested review from
weshaggard,
benbp,
annatisch,
jalauzon-msft,
vincenttran-msft and
weirongw23-msft
as code owners
July 22, 2024 20:28
… package properties?
weshaggard
reviewed
Jul 23, 2024
weshaggard
reviewed
Jul 23, 2024
weshaggard
reviewed
Jul 23, 2024
Co-authored-by: Wes Haggard <[email protected]>
…ve effort where possible
mccoyp
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting some context
This change is best explained in pictures. A standard build looks like this:
With the job dependencies as shown
When an
extension
package is present, this changes. (indicated byAdvancedBuild
boolean fromci.yml
)As you can see. The build is bigger when we know we have an extension package present. But what about when we don't know at template compile time if we have an extension package? That's the world we're heading for with the
pipelinev3
efforts.This PR is setting the stage to allow a PR build which expands and contracts to handle when
azure-storage-extensions
is detected to be part of the necessary build set.What this PR does
advanced
andnon-advanced
buildsstorage
service directory to produce non-linux artifacts whenazure-storage-extension
is detectedENABLE_EXTENSION_BUILD
to skip the build tasks onwindows
andmac
whenazure-storage-extension
(or any extension package later) is NOT detectedAnd the job dependencies will look like: