Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Update tests to only record with Managed Identity #35859

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Jun 1, 2024

Description

In azure-keyvault-administration, backup and restore operations can be authenticated with either Managed Identity or SAS tokens. Since support for the former was only recently added and the setup is harder to record with, recorded tests have used the latter method. This PR updates tests to instead use Managed Identity for recorded tests, and also updates KV documentation to lead users toward Managed Identity instead of SAS tokens.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jun 1, 2024
@mccoyp mccoyp force-pushed the kv-token-cred-tests branch from 06261d7 to 3355e06 Compare June 4, 2024 02:06
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@mccoyp mccoyp marked this pull request as ready for review June 4, 2024 05:11
Copy link
Member

@vcolin7 vcolin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a couple of comments.

@mccoyp mccoyp merged commit 9dc6cc8 into Azure:main Jun 21, 2024
17 checks passed
@mccoyp mccoyp deleted the kv-token-cred-tests branch June 21, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants