-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] [STG94] Support more service versions in Queue, propagate StorageBearer Challenge to all packages #35356
Merged
vincenttran-msft
merged 9 commits into
Azure:feature/storage-stg94
from
vincenttran-msft:vincenttran/support_svc_queue
May 1, 2024
Merged
[Storage] [STG94] Support more service versions in Queue, propagate StorageBearer Challenge to all packages #35356
vincenttran-msft
merged 9 commits into
Azure:feature/storage-stg94
from
vincenttran-msft:vincenttran/support_svc_queue
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackages, queue tests all adjusted
vincenttran-msft
requested review from
annatisch,
jalauzon-msft and
weirongw23-msft
as code owners
April 25, 2024 00:23
/azp run python - storage - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
API change check API changes are not detected in this pull request. |
jalauzon-msft
approved these changes
Apr 30, 2024
/azp run python - storage - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
vincenttran-msft
merged commit May 1, 2024
1be7b83
into
Azure:feature/storage-stg94
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
StorageBearerTokenCredentialPolicy
to all remaining packages (only Blobs had this), allow for the challenge authentication to operateNOTE: Test recordings are missing for
file-share
as I am unsure of the expected behavior. Hitting this:I believe it may be related to the fact that in Files it requires a
token_intent
so maybe expected behavior here is to still fail (or does this mean we shouldn't addStorageBearer
to files?EDIT: Left old test cases for
file-share
, left policy change in