Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] [STG94] Support more service versions in Queue, propagate StorageBearer Challenge to all packages #35356

Conversation

vincenttran-msft
Copy link
Member

@vincenttran-msft vincenttran-msft commented Apr 25, 2024

This PR makes the following changes:

  • Bring the accepted API service versions for Queue to more closely match Blob
  • Apply this change to all packages
  • Bring the StorageBearerTokenCredentialPolicy to all remaining packages (only Blobs had this), allow for the challenge authentication to operate
  • Adjust all test cases in the "bad" audience case to no longer assert for a failure, since they will now auto-resolve

NOTE: Test recordings are missing for file-share as I am unsure of the expected behavior. Hitting this:

>   ???
E   azure.core.exceptions.ClientAuthenticationError: Operation returned an invalid status 'Forbidden'
E   ErrorCode:AuthenticationFailed

I believe it may be related to the fact that in Files it requires a token_intent so maybe expected behavior here is to still fail (or does this mean we shouldn't add StorageBearer to files?

EDIT: Left old test cases for file-share, left policy change in

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Apr 25, 2024
@vincenttran-msft
Copy link
Member Author

/azp run python - storage - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@vincenttran-msft
Copy link
Member Author

/azp run python - storage - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vincenttran-msft vincenttran-msft merged commit 1be7b83 into Azure:feature/storage-stg94 May 1, 2024
20 checks passed
@vincenttran-msft vincenttran-msft deleted the vincenttran/support_svc_queue branch May 1, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants