-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevCenter DataPlane v2023-04-01 stable SDK from TypeSpec #35257
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need async versions of all the samples. Same for tests, we need to have async tests. Also, please update samples to include the AZURE_TENANT_ID for authentication.
sdk/devcenter/azure-developer-devcenter/samples/create_environment_sample.py
Outdated
Show resolved
Hide resolved
sdk/devcenter/azure-developer-devcenter/samples/create_environment_sample.py
Outdated
Show resolved
Hide resolved
sdk/devcenter/azure-developer-devcenter/samples/devbox_action_sample copy.py
Outdated
Show resolved
Hide resolved
sdk/devcenter/azure-developer-devcenter/tests/test_devcenter_operations.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're still missing async samples and tests, we need to have some async coverage before releasing the stable SDK.
sdk/devcenter/azure-developer-devcenter/samples/create_client_sample.py
Outdated
Show resolved
Hide resolved
Added the async tests and samples in the latest iteration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, we just need to get CI passing and add a couple of fixes in the async samples
...nter/azure-developer-devcenter/samples/async_samples/deployment_environments_async_sample.py
Outdated
Show resolved
Hide resolved
...nter/azure-developer-devcenter/samples/async_samples/deployment_environments_async_sample.py
Outdated
Show resolved
Hide resolved
sdk/devcenter/azure-developer-devcenter/samples/async_samples/dev_box_create_async_sample.py
Outdated
Show resolved
Hide resolved
sdk/devcenter/azure-developer-devcenter/samples/async_samples/dev_box_create_async_sample.py
Outdated
Show resolved
Hide resolved
sdk/devcenter/azure-developer-devcenter/samples/async_samples/dev_box_restart_async_sample.py
Outdated
Show resolved
Hide resolved
sdk/devcenter/azure-developer-devcenter/samples/async_samples/dev_box_restart_async_sample.py
Outdated
Show resolved
Hide resolved
sdk/devcenter/azure-developer-devcenter/samples/async_samples/dev_box_create_async_sample.py
Outdated
Show resolved
Hide resolved
sdk/devcenter/azure-developer-devcenter/samples/async_samples/dev_box_action_async_sample.py
Outdated
Show resolved
Hide resolved
sdk/devcenter/azure-developer-devcenter/samples/async_samples/dev_box_action_async_sample.py
Outdated
Show resolved
Hide resolved
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
/azp run python - devcenter - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend rebasing this PR with the latest main
branch if possible. There were a number of recent changes to test sanitizing, which could affect playback tests once this is merged. I see that the test proxy version being used in the development branch is a month behind the latest, meaning that the bulk of changes aren't being used at the moment.
EDIT: Any test issues could alternatively be addressed after merging, since rebasing such a large PR would probably be very difficult -- I definitely wouldn't block this PR on it.
Got it! I will rebase it. |
This reverts commit fcc70bd.
4fde303
to
00da9e5
Compare
/azp run python - devcenter - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - devcenter - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - devcenter - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
We currently have a beta SDK targeting DevCenter 2023-04-01 API, and this PR is to have it released as a stable SDK - our first stable release, targeting same API.
Both SDKs (the last one released and this one) were generated from TypeSpec. The main change introduced was add model generation and updates on tests and samples to reflect that addition.
Arch board meeting occurred but APIView is not yet approved. Their requests have been addressed in this PR.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines
Pipeline runs
Dry runs on the release pipeline:
https://dev.azure.com/azure-sdk/internal/_build?definitionId=5622&_a=summary
List of tests
DevBox
DevCenter
Environments
Also updated samples.