[Storage] added tests for get_account_information across container client and blob client #35067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
|
API change check API changes are not detected in this pull request. |
vincenttran-msft
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Great work!! We can see that we got all the code changes from the "changelog&changes" PR, and after some convincing with the test proxy utility, we have all the recordings necessary! Hopefully the next PR will go more smoothly with all these extraneous issue addressed now 😄
jalauzon-msft
approved these changes
Apr 9, 2024
weirongw23-msft
deleted the
weirongw23/get-account-info-container-blob-level
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_account_informationAPI was exposed in service client, container client, and blob client. Added tests to round out feature.Remaining work is to add individual SAS tests for all three clients.
Service -> Account SAS
Container -> Container SAS
Blob -> Blob SAS