Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip creating automatic API review for ci disabled packages #35002

Merged

Conversation

praveenkuttappan
Copy link
Member

API review token file is not generated for packages if ci_enabled flag is false and this causes APIView to have incorrect reviews. Python needs pregenerated API review token file to create API review.

@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Mar 28, 2024
@praveenkuttappan praveenkuttappan self-assigned this Mar 28, 2024
@praveenkuttappan
Copy link
Member Author

@scbedd @weshaggard Can you please approve this when you get a chance?

@praveenkuttappan praveenkuttappan merged commit c86270b into Azure:main Apr 1, 2024
29 checks passed
@praveenkuttappan praveenkuttappan deleted the skip_apireview_ci_disabled branch April 1, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants