Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring azure-devtools's GH tool dependencies over to azure-sdk-tools #34967

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Mar 27, 2024

Description

After we fully removed azure-devtools from the SDK, @msyyc found that the SDK generation pipeline was now missing a GitPython dependency: #34956.

GitPython and PyGithub were previously being installed via azure-devtools/dev_requirements.txt or update-pr.yml. To fetch them correctly again, we need to add the former [ci_tools] dependencies to [ghtools] in azure-sdk-tools and correctly target [ghtools] from azure-sdk-tools/dev_requirements.txt.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added the Central-EngSys This issue is owned by the Engineering System team. label Mar 27, 2024
@mccoyp mccoyp requested a review from scbedd as a code owner March 27, 2024 17:53
@mccoyp mccoyp changed the title Bring azure-devtools's GitPython dependency over to azure-sdk-tools Bring azure-devtools's GH tool dependencies over to azure-sdk-tools Mar 27, 2024
@mccoyp mccoyp enabled auto-merge (squash) March 27, 2024 18:29
@mccoyp mccoyp merged commit 8ba087e into main Mar 27, 2024
21 checks passed
@mccoyp mccoyp deleted the tools-gitpython-dep branch March 27, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants