-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation turn fix #34886
Merged
singankit
merged 24 commits into
Azure:main
from
nagkumar91:task/fix_conversation_turns
Mar 22, 2024
Merged
Conversation turn fix #34886
singankit
merged 24 commits into
Azure:main
from
nagkumar91:task/fix_conversation_turns
Mar 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' of https://github.com/nagkumar91/azure-sdk-for-python
nagkumar91
requested review from
luigiw,
needuv,
paulshealy1 and
singankit
as code owners
March 21, 2024 22:00
singankit
approved these changes
Mar 21, 2024
ninghu
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Conversation turns was 2 when we counted one set of request, responses.
This now changes to 1.
Internally, for conversation type simulation, we multiply the value by 2 without altering the core logic.
For other types, we have the limit as 1 (which means one request, one response)
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines