Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Authorization Code client_secret kwarg usage #34862

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Update Authorization Code client_secret kwarg usage #34862

merged 8 commits into from
Apr 1, 2024

Conversation

Darkbat91
Copy link
Contributor

Description

  • Update the Authorization code Class to use the kwarg of client_secret as documented in issue
  • Resolve error where class successfully redeems an authorization code by passing client_secret into the AuthorizationCode.get_token() method breaks on a refresh call due to the kwarg getting passed into the request pipeline.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Darkbat91 and others added 3 commits March 20, 2024 12:37
@Darkbat91
fix client_secret
d5773b7 
- use from get_token method if present
- use from init if not in get_token
@Darkbat91
consume client_secret kwarg
13e5483
@Darkbat91
Merge branch 'Azure:main' into main
3e23cf3
@Darkbat91 Darkbat91 requested review from pvaneck, xiangyan99 and a team as code owners March 20, 2024 18:19
@github-actions github-actions bot added Azure.Identity Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Mar 20, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution @Darkbat91! We will review the pull request and get back to you soon.

@Darkbat91
Copy link
Contributor Author

@microsoft-github-policy-service agree

@xiangyan99
Copy link
Member

Can you also add test cases for it?

@xiangyan99 xiangyan99 mentioned this pull request Mar 28, 2024
Closed
@Darkbat91
remove client_secret from get_token
00a96ca 
- client_secret should be utilized from within the constructor instead of the method call
@Darkbat91
add client_secret to get_token method.
07f2e00
@Darkbat91
lint
e447bc9
@xiangyan99 xiangyan99 merged commit 66efa24 into Azure:main Apr 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darkbat91 @xiangyan99