[AutoRelease] t2-workloadssapvirtualinstance-2024-02-20-43646(can only be merged by SDK owner) #34378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
requested review from
ChenxiJiang333,
msyyc and
lmazuel
as code owners
msyyc
approved these changes
Mar 21, 2024
|
/check-enforcer override |
msyyc
reviewed
May 14, 2024
| @@ -467,7 +467,7 @@ def _classify(cls, response, objects): | |||
|
|
|||
| if not isinstance(response, ET.Element): | |||
| rest_api_response_key = cls._get_rest_key_parts(subtype_key)[-1] | |||
| subtype_value = response.pop(rest_api_response_key, None) or response.pop(subtype_key, None) | |||
| subtype_value = response.get(rest_api_response_key, None) or response.get(subtype_key, None) | |||
There was a problem hiding this comment.
Before Azure/autorest.python#2428 fixed, we will make the manual patch for now.
msyyc
reviewed
Oct 9, 2024
|
|
||
| if polling is True: | ||
| polling_method: AsyncPollingMethod = cast( | ||
| AsyncPollingMethod, AsyncPatchArmPolling(lro_delay, lro_options={"final-state-via": "location", "api_version": api_version}, **kwargs) |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/4844
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=4807
BuildTargetingString
azure-mgmt-workloadssapvirtualinstance
Skip.CreateApiReview
true