[AppConfig] Support monitor page changes by page etag #34346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
YalinLi0312
requested review from
jsquire,
kinelski,
HarshaNalluru,
mssfang and
minhanh-phan
xiangyan99
reviewed
Mar 7, 2024
...onfiguration/azure-appconfiguration/azure/appconfiguration/_azure_appconfiguration_client.py
Outdated
Show resolved
Hide resolved
xiangyan99
reviewed
Mar 7, 2024
sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py
Outdated
Show resolved
Hide resolved
xiangyan99
reviewed
Mar 7, 2024
johanste
reviewed
Mar 7, 2024
sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py
Outdated
Show resolved
Hide resolved
johanste
reviewed
Mar 7, 2024
sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py
Outdated
Show resolved
Hide resolved
xiangyan99
reviewed
Mar 13, 2024
xiangyan99
reviewed
Mar 13, 2024
sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py
Show resolved
Hide resolved
xiangyan99
reviewed
Mar 13, 2024
sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py
Show resolved
Hide resolved
xiangyan99
reviewed
Mar 14, 2024
sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py
Show resolved
Hide resolved
xiangyan99
approved these changes
Mar 14, 2024
mrm9084
reviewed
Nov 8, 2024
| index += 1 | ||
| while continuation_token: | ||
| request = HttpRequest( | ||
| method="GET", url=f"{continuation_token}", headers={"If-None-Match": page_etags[index]} |
There was a problem hiding this comment.
Is there no way to do this in the SDK?
There was a problem hiding this comment.
@mrm9084 : Commenting on a PR that was closed out 8 months ago is probably not the most efficient path for a question. I'd suggest starting an email thread and adding detail around the end-to-end scenario that you're interested in.
There was a problem hiding this comment.
I was using this a link to the line that I was looking at to send to Yalin.
There was a problem hiding this comment.
This feature is in all of the other SDKs, I'm trying to figure out why not python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
send_request()page_etagwhich lives in response header through custom iterator.