[SB] next-mypy #31864
Merged
[SB] next-mypy #31864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
l0lawrence
requested review from
annatisch,
kashifkhan and
swathipil
as code owners
l0lawrence
commented
Sep 5, 2023
l0lawrence
commented
Sep 6, 2023
sdk/servicebus/azure-servicebus/azure/servicebus/_common/auto_lock_renewer.py
Show resolved
Hide resolved
kashifkhan
reviewed
Sep 6, 2023
...ebus/azure-servicebus/samples/async_samples/authenticate_using_azure_sas_credential_async.py
Outdated
Show resolved
Hide resolved
kashifkhan
reviewed
Sep 6, 2023
sdk/servicebus/azure-servicebus/samples/sync_samples/sample_code_servicebus.py
Show resolved
Hide resolved
l0lawrence
commented
Sep 7, 2023
sdk/servicebus/azure-servicebus/samples/sync_samples/send_and_receive_amqp_annotated_message.py
Outdated
Show resolved
Hide resolved
swathipil
reviewed
Sep 7, 2023
sdk/servicebus/azure-servicebus/azure/servicebus/_common/auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/amqp/_amqp_message.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/amqp/_amqp_message.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/amqp/_amqp_message.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/amqp/_amqp_message.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/samples/sync_samples/send_and_receive_amqp_annotated_message.py
Outdated
Show resolved
Hide resolved
kashifkhan
approved these changes
Sep 19, 2023
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mccoyp
pushed a commit
to mccoyp/azure-sdk-for-python
that referenced
this pull request
Oct 7, 2023
* sb mypy start * servicebus mypy * pylint * union typing * missing optional * make str * typing * align * remove type * remove try/except * remove try.except * type is mapping * remove cast * both type * try iterable * comments + no list typing * fix isinstance * pylint changes * reset commit to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next-mypy changes (mostly sample related)
Will have a follow up PR addressing removing the instances of type: ignore that we have in our code
fixes #31672