Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML][Pipelines] feat: make unknown field notification warning instead of info #30642

Merged
merged 1 commit into from
Jun 6, 2023
Merged

[ML][Pipelines] feat: make unknown field notification warning instead of info #30642

merged 1 commit into from
Jun 6, 2023

Conversation

elliotzh
Copy link
Contributor

@elliotzh elliotzh commented Jun 6, 2023 •
edited
Loading

Description

Given all nodes have strong type schema, we change the log level of unknown notification for pipeline nodes from INFO to WARNING.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@elliotzh elliotzh force-pushed the zhangxingzhi/make-unknown-field-warning branch from 40bc52f to 5085540 Compare June 6, 2023 02:54
@elliotzh elliotzh added the ML-Pipelines AreaPath label Jun 6, 2023
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@wangchao1230 wangchao1230 merged commit aee4f62 into Azure:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@D-W- D-W- D-W- approved these changes

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit

@diondrapeck diondrapeck Awaiting requested review from diondrapeck

@luigiw luigiw Awaiting requested review from luigiw

@kdestin kdestin Awaiting requested review from kdestin

@MilesHolland MilesHolland Awaiting requested review from MilesHolland

@needuv needuv Awaiting requested review from needuv

@nemanjarajic nemanjarajic Awaiting requested review from nemanjarajic

@nthandeMS nthandeMS Awaiting requested review from nthandeMS

Assignees
No one assigned
Labels
Machine Learning ML-Pipelines AreaPath
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elliotzh @azure-sdk @D-W- @wangchao1230