Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] [Pipelines] perf optimization: resolve all leaf node concurrently #30281

Conversation

elliotzh
Copy link
Contributor

@elliotzh elliotzh commented May 6, 2023

Description

update the function to divide nodes in a pipeline component into layers and put all leaf nodes (potentially involve slow operations like IO, file uploading and artifact downloading) at the last layer.

In this way, all slow operations can be done concurrently so improve the overall performance.

L2 first submission perf: 446s =>320s

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@elliotzh elliotzh added the ML-Pipelines AreaPath label May 6, 2023
@elliotzh elliotzh changed the title perf optimization: resolve all leaf node concurrently [ML] [Pipelines] perf optimization: resolve all leaf node concurrently May 6, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@wangchao1230 wangchao1230 merged commit 564928c into Azure:main May 6, 2023
@elliotzh elliotzh deleted the zhangxingzhi/skip-validation-for-components-in-subgraph branch May 6, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants