Core typings #28114
Merged
Core typings #28114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
lmazuel
requested review from
annatisch,
johanste,
xiangyan99,
tjprescott,
iscai-msft and
kashifkhan
as code owners
There was a problem hiding this comment.
Mostly nits. Also, I think we should opt azure-core into running verifytypes CI checks: https://github.com/Azure/azure-sdk-for-python/blob/main/tools/azure-sdk-tools/ci_tools/environment_exclusions.py#L215
sdk/core/azure-core/azure/core/pipeline/policies/_authentication_async.py
Outdated
Show resolved
Hide resolved
kashifkhan
reviewed
Jan 12, 2023
xiangyan99
approved these changes
Jan 19, 2023
kashifkhan
approved these changes
Jan 19, 2023
kristapratico
approved these changes
Jan 19, 2023
|
/azp run python - identity - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
reviewed
Jan 24, 2023
sdk/core/azure-core/azure/core/pipeline/policies/_authentication.py
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/azure/core/pipeline/policies/_base_async.py
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/azure/core/utils/_pipeline_transport_rest_shared.py
Outdated
Show resolved
Hide resolved
…on.py Co-authored-by: Anna Tisch <[email protected]>
Co-authored-by: Anna Tisch <[email protected]>
Co-authored-by: Anna Tisch <[email protected]>
annatisch
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving Typings for azure-core. Maybe even to the point of enabling pyright. Fix some Python 2 at the same time.