Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mldesigner] Centralize private imports for mldesigner #27220

Merged
merged 17 commits into from
Feb 1, 2023
Merged

[mldesigner] Centralize private imports for mldesigner #27220

merged 17 commits into from
Feb 1, 2023

Conversation

0mza987
Copy link
Contributor

@0mza987 0mza987 commented Nov 1, 2022 •
edited
Loading

Description

  • Centralize all modules/functions that used by mldesigner at one single file, in order to prevent from main package change breaking mldesigner code.

Related PR in sdk-cli-v2: PR - 924011

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@0mza987 0mza987 added the ML-Pipelines AreaPath label Nov 16, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@0mza987 0mza987 force-pushed the hod/mldesigner_imports branch 3 times, most recently from 4e5d8ce to c9aade5 Compare January 17, 2023 03:07
@0mza987 0mza987 force-pushed the hod/mldesigner_imports branch from c9aade5 to af7fcc0 Compare January 31, 2023 06:19
@0mza987 0mza987 force-pushed the hod/mldesigner_imports branch from ddeb796 to 8acab3c Compare February 1, 2023 04:07
@wangchao1230 wangchao1230 merged commit 150594c into Azure:main Feb 1, 2023
@0mza987 0mza987 deleted the hod/mldesigner_imports branch February 2, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliotzh elliotzh elliotzh left review comments

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@zhengfeiwang zhengfeiwang zhengfeiwang approved these changes

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit

@diondrapeck diondrapeck Awaiting requested review from diondrapeck

@luigiw luigiw Awaiting requested review from luigiw

@harneetvirk harneetvirk Awaiting requested review from harneetvirk

@kdestin kdestin Awaiting requested review from kdestin

@MilesHolland MilesHolland Awaiting requested review from MilesHolland

@needuv needuv Awaiting requested review from needuv

@nthandeMS nthandeMS Awaiting requested review from nthandeMS

Assignees
No one assigned
Labels
ML-Pipelines AreaPath
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0mza987 @azure-sdk @elliotzh @zhengfeiwang @wangchao1230