Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricadvisor] Autorest regeneration & update to setup.py #26122

Closed

Conversation

wonhyeongseo
Copy link
Contributor

Description

Fix #25917
This PR addresses the concerns of the above issue with updates to the dependencies in setup.py.

before

install_requires=[
"azure-core<2.0.0,>=1.23.0",
"msrest>=0.6.21",
'six>=1.11.0',
],

after

install_requires=[
"azure-core<2.0.0,>=1.24.0",
"msrest>=0.7.1",
],

Additionally with regenerated code from autorest. Thanks @iscai-msft !

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added Cognitive - Metrics Advisor customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Sep 9, 2022
@ghost
Copy link

ghost commented Sep 9, 2022

Thank you for your contribution wonhyeongseo! We will review the pull request and get back to you soon.

@wonhyeongseo
Copy link
Contributor Author

Found some tests are failing, will add a commit to fix that shortly. Sorry for not checking earlier.

This is a generated autorest code with the following dependency updates:
* update msrest to 0.7.1 from 0.6.21
* remove unused six package

Co-authored-by: wonder6845 <[email protected]>
@wonhyeongseo wonhyeongseo force-pushed the metricadvisor-autorest-n-setup branch from 0d11ccc to 89349b0 Compare September 14, 2022 11:56
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Dec 2, 2022
@ghost
Copy link

ghost commented Dec 2, 2022

Hi @wonhyeongseo. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Dec 9, 2022
@ghost
Copy link

ghost commented Dec 9, 2022

Hi @wonhyeongseo. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cognitive - Metrics Advisor customer-reported Issues that are reported by GitHub users external to the Azure organization. no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[metricsadvisor] update min dependency package
2 participants