Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Fixed pylint error #25833

Closed
wants to merge 1 commit into from
Closed

[QA] Fixed pylint error #25833

wants to merge 1 commit into from

Conversation

wonhyeongseo
Copy link
Contributor

Description

closes #25557

Hello, @kristapratico!

I went through the imports and found operations/_operations.py wants argument name of option specifically. Should I try this with a different approach?

Please let me know what you think, thank you. I hope you have a wonderful day!

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 24, 2022
@ghost
Copy link

ghost commented Aug 24, 2022

Thank you for your contribution wonhyeongseo! We will review the pull request and get back to you soon.

@wonhyeongseo wonhyeongseo mentioned this pull request Aug 24, 2022
Closed
@kristapratico
Copy link
Member

@wonhyeongseo thanks for looking into this! I described the problem and solution in the issue, but I'll paste it again here:

short_answer_options is the correct name for this keyword argument. We can't change the name to options because 1) this is a breaking change for our customers and 2) get_answers already takes a positional argument called options which accepts an AnswersOptions type. That being said, the error is arising from a naming clash in the generated code vs the patched code. To fix this, we will need to regenerate the code using the post-processing script mentioned in #25557 (comment). Let me know if you're up for trying that script, happy to help.

Let me know if you have any questions. Going to close this PR for now, feel free to open a new one with the proposed the solution.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Sep 20, 2023
@niteshvijay-ms @AdrianSibajaRetana
@Achint-Agrawal @pjohari-ms @DrewKaufmann @ArthurMa1978
CodeGen from PR 25326 in Azure/azure-rest-api-specs
130e930 
[Hub Generated] Review request for Microsoft.DocumentDB to add version preview/2023-09-15-preview (Azure#25326)

* Adds base for updating Microsoft.DocumentDB from version preview/2023-03-15-preview to version 2023-09-15-preview

* Updates readme

* Updates API version in new specs and examples

* Add remoteAccountName in DTS create job

* Update cosmos-db.json

* Update custom-words.txt

* Added EnablePriorityBasedExecution and DefaultPriorityLevel properties (Azure#25470)

* Added Changes for Priority Based Execution

* Whitespace change

---------

Co-authored-by: Achint Agrawal <[email protected]>

* Added SecuredByPerimeter enum value

* Added liana's 04-15 changes - MaximumThroughput

* Fix comment

* Update model name

* Revert changes to model

* Added clarification for throughput/autoscaleSettings option

* Update MI Cassandra preview swagger (Azure#25704)

* Updated preview swagger

* Removed repair additions and updated example files

* fix examples

* Fix prettier check for examples (Azure#25833)

---------

Co-authored-by: Nitesh Vijay <[email protected]>
Co-authored-by: AdrianSibajaRetana <[email protected]>
Co-authored-by: Achint-Agrawal <[email protected]>
Co-authored-by: Achint Agrawal <[email protected]>
Co-authored-by: Praful Johari <[email protected]>
Co-authored-by: carjackson-msft <[email protected]>
Co-authored-by: DrewKaufmann <[email protected]>
Co-authored-by: Arthur Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico Awaiting requested review from kristapratico kristapratico is a code owner

Assignees
No one assigned
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] investigate why pylance shows linting error for get_answers
2 participants
@wonhyeongseo @kristapratico