[Test Proxy] Fix parameter reference in stop_record_or_playback
#25725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
approved these changes
Aug 16, 2022
|
/check-enforcer override |
wonder6845
pushed a commit
to wonder6845/azure-sdk-for-python
that referenced
this pull request
Aug 23, 2022
mccoyp
added a commit
to mccoyp/azure-sdk-for-python
that referenced
this pull request
Sep 22, 2022
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Sep 22, 2023
Release elasticsan microsoft.elastic san 2023 01 01 ga (Azure#25687) * Adds base for updating Microsoft.ElasticSan from version preview/2022-12-01-preview to version 2023-01-01 * Updates readme * Updates API version in new specs and examples * Added snapshot API & SourceId change (Azure#25073) * Added snapshot API & SourceId change * removed state from virtualNetworkRule * add CMK changes * add object type on properties * add managedby property * Removed PATCH Snapshot API, Added forceDeleteFlags for volume, added provisioning state from volume, added publicNetworkAccess * Added proper examples * resolved Prettier check * removed export, added enum for force-delete * Updated operationID & resolved comments --------- Co-authored-by: Harshjeet Aulakh <[email protected]> * Adding update to x-ms-mutability (Azure#25725) * Adding update to x-ms-mutability * updated examples as per need of teraform * added managedBy in Update properties * prettier check --------- Co-authored-by: Harshjeet Aulakh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
test_outputparameter in the test proxy infra'sstop_record_or_playbackmethod was recently changed to (more accurately) betest_variables. As part of the test tooling refactor, this name change got mismatched such that this code raises an error over an undefinedtest_outputvariable.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines