-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont default to RequestsTransport #25618
Conversation
unsure how to test this |
/azp run python - keyvault - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments also apply to async clients (and their async client bases -- example) 🙂
...eyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/client_base.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks again for tackling this 🙂
API change check APIView has identified API level changes in this PR and created following API reviews. azure-keyvault-certificates |
Thanks @mccoyp. Please merge at your convenience. |
Adding Provisioning,PendingCommit values in the ConfigurationState.. (Azure#25618) * Adding Provisioning,PendingCommit values in the ConfigurationState.. * Changes in the Internet Gateway Rules. * 1. Reverting the changes in the InternetGatewayRules. 2. Added option enum param to the body in Post Action Upgrade
Description
Fix for #25533
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines