Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont default to RequestsTransport #25618

Merged
merged 6 commits into from
Aug 18, 2022
Merged

Dont default to RequestsTransport #25618

merged 6 commits into from
Aug 18, 2022

Conversation

Stevenjin8
Copy link
Contributor

@Stevenjin8 Stevenjin8 commented Aug 9, 2022

Description

Fix for #25533

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the KeyVault label Aug 9, 2022
@Stevenjin8
Copy link
Contributor Author

unsure how to test this

@Stevenjin8
Copy link
Contributor Author

/azp run python - keyvault - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Stevenjin8 Stevenjin8 marked this pull request as ready for review August 9, 2022 21:06
Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments also apply to async clients (and their async client bases -- example) 🙂

@Stevenjin8 Stevenjin8 requested a review from mccoyp August 18, 2022 20:15
Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks again for tackling this 🙂

@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 18, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-keyvault-certificates
azure-keyvault-keys
azure-keyvault-secrets

@Stevenjin8
Copy link
Contributor Author

Looks good to me! Thanks again for tackling this 🙂

Thanks @mccoyp. Please merge at your convenience.

@mccoyp mccoyp merged commit 65ff178 into main Aug 18, 2022
@mccoyp mccoyp deleted the fix/kv-core-imports branch August 18, 2022 21:20
wonder6845 pushed a commit to wonder6845/azure-sdk-for-python that referenced this pull request Aug 23, 2022
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Sep 22, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Sep 22, 2023
Adding Provisioning,PendingCommit values in the ConfigurationState.. (Azure#25618)

* Adding Provisioning,PendingCommit values in the ConfigurationState..

* Changes in the Internet Gateway Rules.

* 1. Reverting the changes in the InternetGatewayRules.
2. Added option enum param to the body in Post Action Upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants