Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to the GA version of the datamigration sdk #2561

Merged
merged 6 commits into from
May 15, 2018
Merged

Add unit tests to the GA version of the datamigration sdk #2561

merged 6 commits into from
May 15, 2018

Conversation

vchske
Copy link
Contributor

@vchske vchske commented May 15, 2018

No description provided.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented May 15, 2018

Codecov Report

Merging #2561 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2561      +/-   ##
==========================================
+ Coverage   55.17%   55.24%   +0.07%     
==========================================
  Files        6628     6833     +205     
  Lines      144734   147701    +2967     
==========================================
+ Hits        79854    81602    +1748     
- Misses      64880    66099    +1219
Impacted Files Coverage Δ
...gmt/datamigration/models/database_file_info_py3.py 33.33% <0%> (ø)
...re/mgmt/datamigration/models/resource_sku_costs.py 55.55% <0%> (ø)
.../models/connect_to_target_sql_db_task_input_py3.py 71.42% <0%> (ø)
...s/migrate_sql_server_sql_mi_task_properties_py3.py 55.55% <0%> (ø)
...ct_to_source_sql_server_task_output_login_level.py 41.66% <0%> (ø)
...te_sql_server_sql_mi_task_output_database_level.py 33.33% <0%> (ø)
...o_source_sql_server_task_output_agent_job_level.py 38.46% <0%> (ø)
.../datamigration/models/available_service_sku_py3.py 50% <0%> (ø)
.../azure/mgmt/datamigration/models/database_table.py 62.5% <0%> (ø)
...odels/migrate_sql_server_sql_mi_task_properties.py 55.55% <0%> (ø)
... and 195 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ff936...c462995. Read the comment docs.

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@lmazuel lmazuel merged commit c9860e9 into Azure:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants