Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Proxy] Align sanitizers, matchers, and transforms #25258

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Jul 15, 2022

Description

This PR initially was just going to be a fix to replace add_request_subscription_id_sanitizer with add_uri_subscription_id_sanitizer -- the former sanitizer either never existed, or was replaced with the latter sanitizer without me noticing. (In either case, my bad!)

After fixing this sanitizer though, I noticed that multiple sanitizers had been given a condition option since the time I added Python support for them. This PR adds that support where applicable.

Finally, this adds support for any other matchers, sanitizers, and transforms that are supported by the test proxy but haven't had Python support.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
    • Changes verified to work locally with SDK tests.

@mccoyp mccoyp requested a review from scbedd July 15, 2022 23:56
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is great.

I'd like a quick offline conversation to discuss session vs individual recording settings, and then we can get this in.

@mccoyp mccoyp enabled auto-merge (squash) July 21, 2022 23:59
@mccoyp mccoyp merged commit fb9f328 into Azure:main Jul 22, 2022
@mccoyp mccoyp deleted the proxy-sanitizer-fix branch July 22, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants