Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Proxy] Guidance for expected DNS lookup failures #23966

Merged
merged 2 commits into from
Apr 13, 2022
Merged

[Test Proxy] Guidance for expected DNS lookup failures #23966

merged 2 commits into from
Apr 13, 2022

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Apr 13, 2022

Description

Provides guidance for the error described in Azure/azure-sdk-tools#2907.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • N/A Pull request includes test coverage for the included changes.

@mccoyp mccoyp added Docs Client This issue points to a problem in the data-plane of the library. labels Apr 13, 2022
scbedd
scbedd approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits that you do not need to listen to.

@mccoyp mccoyp merged commit 6a853e6 into main Apr 13, 2022
@mccoyp mccoyp deleted the proxy-dns-troubleshoot branch April 13, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scbedd scbedd scbedd approved these changes

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccoyp @scbedd