Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address API view issues #20407

Merged
merged 11 commits into from
Aug 25, 2021
Merged

Address API view issues #20407

merged 11 commits into from
Aug 25, 2021

Conversation

rakshith91
Copy link
Contributor

No description provided.

@rakshith91
Copy link
Contributor Author

/azp run python - monitor - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - monitor - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - monitor - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - monitor - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91 rakshith91 enabled auto-merge (squash) August 25, 2021 15:58
Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits, but otherwise LGTM!

@@ -7,7 +7,7 @@
from azure.monitor.query import MetricsQueryClient, MetricAggregationType
from azure.identity import DefaultAzureCredential

urllib3.disable_warnings()
# urllib3.disable_warnings()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be removed rather than just commented out?

with pytest.raises(TypeError):
LogsBatchQuery(
query="AzureActivity | summarize count()",
workspace_id= os.environ['LOG_WORKSPACE_ID']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
workspace_id= os.environ['LOG_WORKSPACE_ID']
workspace_id=os.environ['LOG_WORKSPACE_ID']

LogsBatchQuery(
query="AzureActivity | summarize count()",
timespan=timedelta(hours=1),
workspace_id= os.environ['LOG_WORKSPACE_ID']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
workspace_id= os.environ['LOG_WORKSPACE_ID']
workspace_id=os.environ['LOG_WORKSPACE_ID']

Comment on lines +132 to +135
query= """AppRequests | take 5 |
summarize avgRequestDuration=avg(DurationMs) by bin(TimeGenerated, 10m), _ResourceId""",
timespan=(datetime(2021, 6, 2), timedelta(hours=1)),
workspace_id= os.environ['LOG_WORKSPACE_ID']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
query= """AppRequests | take 5 |
summarize avgRequestDuration=avg(DurationMs) by bin(TimeGenerated, 10m), _ResourceId""",
timespan=(datetime(2021, 6, 2), timedelta(hours=1)),
workspace_id= os.environ['LOG_WORKSPACE_ID']
query="""AppRequests | take 5 |
summarize avgRequestDuration=avg(DurationMs) by bin(TimeGenerated, 10m), _ResourceId""",
timespan=(datetime(2021, 6, 2), timedelta(hours=1)),
workspace_id=os.environ['LOG_WORKSPACE_ID']

Comment on lines +138 to +140
query= """AppRequests | take 5 |
summarize avgRequestDuration=avg(DurationMs) by bin(TimeGenerated, 10m), _ResourceId""",
workspace_id= os.environ['LOG_WORKSPACE_ID'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
query= """AppRequests | take 5 |
summarize avgRequestDuration=avg(DurationMs) by bin(TimeGenerated, 10m), _ResourceId""",
workspace_id= os.environ['LOG_WORKSPACE_ID'],
query="""AppRequests | take 5 |
summarize avgRequestDuration=avg(DurationMs) by bin(TimeGenerated, 10m), _ResourceId""",
workspace_id=os.environ['LOG_WORKSPACE_ID'],


"""
count_
0 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which print statement does this correspond to? line 149?

#### Results in Key Value form


Very Simlar to above:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
Very Simlar to above:
Very similar to above:

df = pd.DataFrame(table.rows, columns=table.columns)
print(df.to_dict(orient='records'))
print("\n\n-------------------------\n\n")
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't have the results here for this one. I'm assuming it's because the results are the same as the previous scenario? If so, it might be useful to have a comment saying something like:
`### output is the same as "...." scenario

print(query())

"""
TimeGenerated _ResourceId avgRequestDuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
I'm assuming that this was copied from the actual resulting output, but for some reason, the indenting here is different from, for example, line 165 and 177. Do you know why this is?

@rakshith91 rakshith91 merged commit 37cb22c into Azure:main Aug 25, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Aug 25, 2021
…into switch_to_rest

* 'main' of https://github.com/Azure/azure-sdk-for-python:
  Address API view issues (Azure#20407)
  skip custom translation model samples (Azure#20414)
  [purview account] first release for azure-purview-account (Azure#20335)
  improve docs and samples for glossaries and custom models (Azure#18587)
  Sync eng/common directory with azure-sdk-tools for PR 1918 (Azure#20342)
  Update .docsettings.yml (Azure#20402)
  improve begin_translation docstring (Azure#20401)
  [translation] fix poller.details (Azure#20392)
  Chain exceptions from LibsecretPersistence (Azure#20380)
  [AutoRelease] t2-datamigration-2021-08-19-04035 (Azure#20349)
  [AutoRelease] t2-policyinsights-2021-08-23-78735 (Azure#20381)
  [AutoRelease] t2-servicebus-2021-08-19-00756 (Azure#20350)
  [AutoRelease] t2-costmanagement-2021-07-27-84467 (Azure#19949)
  keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (Azure#20391)
  Add Cloud Configuration section to Identity readme (Azure#20373)
  Consistency related changes (Azure#20385)
iscai-msft added a commit that referenced this pull request Aug 25, 2021
…into header_tuples

* 'main' of https://github.com/Azure/azure-sdk-for-python: (23 commits)
  make core tests offline (#19986)
  [translation] naming alignment (#20406)
  Address API view issues (#20407)
  skip custom translation model samples (#20414)
  [purview account] first release for azure-purview-account (#20335)
  improve docs and samples for glossaries and custom models (#18587)
  Sync eng/common directory with azure-sdk-tools for PR 1918 (#20342)
  Update .docsettings.yml (#20402)
  improve begin_translation docstring (#20401)
  [translation] fix poller.details (#20392)
  Chain exceptions from LibsecretPersistence (#20380)
  [AutoRelease] t2-datamigration-2021-08-19-04035 (#20349)
  [AutoRelease] t2-policyinsights-2021-08-23-78735 (#20381)
  [AutoRelease] t2-servicebus-2021-08-19-00756 (#20350)
  [AutoRelease] t2-costmanagement-2021-07-27-84467 (#19949)
  keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (#20391)
  Add Cloud Configuration section to Identity readme (#20373)
  Consistency related changes (#20385)
  Document Pod Identity's special use of client_id (#20377)
  [rest] use azure json encoder for json input bodies (#20361)
  ...
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Aug 26, 2021
* logs client

* lc-2

* models changes

* more changes

* more changes

* more arch changes

* changelog

* tests

* lint

* fix tests

* timespan
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Aug 26, 2021
* logs client

* lc-2

* models changes

* more changes

* more changes

* more arch changes

* changelog

* tests

* lint

* fix tests

* timespan
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Aug 30, 2021
* logs client

* lc-2

* models changes

* more changes

* more changes

* more arch changes

* changelog

* tests

* lint

* fix tests

* timespan
msyyc added a commit that referenced this pull request Aug 30, 2021
* CodeGen from PR 15691 in Azure/azure-rest-api-specs
[NetAppFiles] fix default in volumeproperties (#15691)

* fix default in volumeproperties

* Update description

* Update description

Co-authored-by: Audunn Baldvinsson <[email protected]>

* version,CHANGELOG

* test

* bump node version (#20353)

* Remove old unused update changelog script (#20357)

Co-authored-by: Wes Haggard <[email protected]>

* Handle value types for results (#20358)

* Handle value types for results

* update test

* lint

* comprehension

* more precis

* fix test

* [rest] change text from a property to a method (#20290)

* [ServiceBus] update migration guide with message count info (#20360)

#20245

* Update CODEOWNERS (#20366)

* More Renaming in query (#20303)

* More Reanaming in query

* changelog

* commit 2

* some changes

* remove errror

* Update sdk/monitor/azure-monitor-query/azure/monitor/query/_models.py

* Apply suggestions from code review

Co-authored-by: Adam Ling (MSFT) <[email protected]>

* Update sdk/monitor/azure-monitor-query/CHANGELOG.md

Co-authored-by: Adam Ling (MSFT) <[email protected]>

* Fix Monitor opentelemetry exporter readme issues (#19038)

* [Key Vault] Add 7.3-preview support for administration (#20364)

* Update metadata values (#20365)

* Update metadata values

* distributed trace

* oops

* Update sdk/monitor/azure-monitor-query/CHANGELOG.md

* Apply suggestions from code review

* Bug fix for pipeline downloading incorrect package ver (#20294)

* Bug fix: pipeline to download correct package ver

* Update clean version

* Update clean version

* Cleanup

* Cleanup

* Cleanup

* Cleanup

* Comments added

* Testing

* Final-Version

* CertificateCredential supports PKCS12 certs (#16384)

* [rest] use azure json encoder for json input bodies (#20361)

* Document Pod Identity's special use of client_id (#20377)

* Consistency related changes (#20385)

* time stamp

* Rename AggragationType to MetricAggregationType

* Metric Class

* logs batch result

* MetricNamespaceClassification

* LogsTable + LogsTableColumn

* lint

* more lint

* Add Cloud Configuration section to Identity readme (#20373)

* keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (#20391)

* [AutoRelease] t2-costmanagement-2021-07-27-84467 (#19949)

* CodeGen from PR 15291 in Azure/azure-rest-api-specs
Updating Query filter description (#15291)

Co-authored-by: Jorge Chavez Nieto <[email protected]>

* version,CHANGELOG

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: Jorge Chavez Nieto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* [AutoRelease] t2-servicebus-2021-08-19-00756 (#20350)

* CodeGen from PR 14749 in Azure/azure-rest-api-specs
add apitestErrorCode doc (#14749)

* add apitestErrorCode doc

* add armRPC doc

* add roundTripInconsistentProperty doc

* small fix

* update

* update signalR armTemplate

* update yaml

* new file

* add testScenario with armTemplate

* update doc

* update readme.md

* update doc

* update NOTE section

* add signalRCreateOrUpdate example file

* udpate doc

* add generate test scenario section

* update doc

* add serviceFacbric test scenario file

* update managedClusters.yaml

* update generateABasicTestScenario.md

* update features doc

* add run api test gif

* version,CHANGELOG

* test

* Update test_cli_mgmt_servicebus_namespace.py

* Update test_queues.py

* Update test_queues.py

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <[email protected]>
Co-authored-by: Jiefeng Chen <[email protected]>

* [AutoRelease] t2-policyinsights-2021-08-23-78735 (#20381)

* CodeGen from PR 15165 in Azure/azure-rest-api-specs
[policyinsights] Fix next_link (#15165)

* fix next_link

* directive

* Update readme.nodejs.md

* js directvie

* Update readme.md

* supress other language

* Update readme.go.md

* swagger lint

* swagger lint

* swagger lint

* Update readme.md

* version,CHANGELOG

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <[email protected]>

* [AutoRelease] t2-datamigration-2021-08-19-04035 (#20349)

* CodeGen from PR 15259 in Azure/azure-rest-api-specs
Dev datamigration microsoft.data migration 2021 06 30 (#15259)

* Created new api version and refactoring changes (such as fixing new build restrictions)

* Adding breaking changes

* Adding location to the services update example

* Adding location for projects update and refactoring the task command

* Resolving tasks command ModelValidation test failure

* Resolving issue based on zhenglaizhang's recommendation

* Adding comma to resolve issue

Co-authored-by: Artem Pavlichenko <[email protected]>

* version,CHANGELOG

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: Artem Pavlichenko <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* Chain exceptions from LibsecretPersistence (#20380)

* [translation] fix poller.details (#20392)

* fixing docstring types for async client

* populate poller.details.id immediately

* pylint

* add bug fix to changelog

* improve begin_translation docstring (#20401)

* Update .docsettings.yml (#20402)

* Sync eng/common directory with azure-sdk-tools for PR 1918 (#20342)

* Stress test deployment script resiliency fixes

* Use PSModule-Helpers to install powershell-yaml

Co-authored-by: Ben Broderick Phillips <[email protected]>

* improve docs and samples for glossaries and custom models (#18587)

* update the readme

* update readme file

* added custom translation samples

* fix 'no-locale' thing in links

* update glossary docs

* update glossaries

* link to sample glossaries instead of writing code in readme

* update custom model sample linking

* remove relative linking in readme

* make subheadings in bold text to be more readable

* conform with 'Document Translation' naming

* disambiguate container sas url

* capitaliz Azure name

* remove misplaced period

* update samples -> custom model

* update async sample -> custom model

* remove localization from url

* update readme with new file types for glossaries

* adding sample glossaries -> xlf

* white space

* use simplified single input method

* update 'job' terminology

* update azure-core naming

* update glossary blob file reference name

* link to supported glossaries table

* remove locale from url

* [purview account] first release for azure-purview-account (#20335)

* purview account

* CI

* verion-tolerant

* endpoint order

* add test for collections

* Update CHANGELOG.md

* review

* update reamdme

* skip custom translation model samples (#20414)

* Address API view issues (#20407)

* logs client

* lc-2

* models changes

* more changes

* more changes

* more arch changes

* changelog

* tests

* lint

* fix tests

* timespan

* [translation] naming alignment (#20406)

* list_all_translation_statuses -> list_translation_statuses

* list_all_document_statuses -> list_document_statuses

* cancelled -> canceled, cancelling -> canceling

* FileFormat -> DocumentTranslationFileFormat

* update changelog

* make core tests offline (#19986)

* make core tests offline

* clean up

* use localhost instead of 127.0.0.1

* update

* update

* update

* Get rid of LogsBatchQueryResult (#20418)

* Get rid of LogsBatchQueryResult

* Update sdk/monitor/azure-monitor-query/README.md

* oops

* comments

* [AutoRelease] t2-iothub-2021-08-25-25696 (#20409)

* CodeGen from PR 15722 in Azure/azure-rest-api-specs
Removing readonly for isVerified property as it is no more readonly property (#15722)

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422)

* CodeGen from PR 15381 in Azure/azure-rest-api-specs
Update readme.md (#15381)

* version,CHANGELOG

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* Stip empty changelog sections before release (#20437)

Co-authored-by: Chidozie Ononiwu <[email protected]>

* Update question-answering readme links (#20439)

* ensure test principal creation succeeds properly (#20446)

Co-authored-by: scbedd <[email protected]>

* New dummy password in README (#20328)

* Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450)

* Bug fix: Storing .env file for bicep file at service dir

* Styling

Co-authored-by: Albert Cheng <[email protected]>

* [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423)

* CodeGen from PR 15458 in Azure/azure-rest-api-specs
Add rotation permission (#15458)

* Add rotation permission

* Update keys.json

Remove required from lifetimeActions

* Change to expiryTime

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* new recordings

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: Audunn Baldvinsson <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: iscai-msft <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Rakshith Bhyravabhotla <[email protected]>
Co-authored-by: swathipil <[email protected]>
Co-authored-by: McCoy Patiño <[email protected]>
Co-authored-by: Adam Ling (MSFT) <[email protected]>
Co-authored-by: Tong Xu (MSFT) <[email protected]>
Co-authored-by: ckairen <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Azure CLI Bot <[email protected]>
Co-authored-by: Jorge Chavez Nieto <[email protected]>
Co-authored-by: Zed Lei <[email protected]>
Co-authored-by: Jiefeng Chen <[email protected]>
Co-authored-by: Artem Pavlichenko <[email protected]>
Co-authored-by: Krista Pratico <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Mohamed Shaban <[email protected]>
Co-authored-by: msyyc <[email protected]>
Co-authored-by: Xiang Yan <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: annatisch <[email protected]>
Co-authored-by: Albert Cheng <[email protected]>
iscai-msft pushed a commit that referenced this pull request Sep 29, 2021
* logs client

* lc-2

* models changes

* more changes

* more changes

* more arch changes

* changelog

* tests

* lint

* fix tests

* timespan
iscai-msft added a commit that referenced this pull request Sep 29, 2021
* CodeGen from PR 15691 in Azure/azure-rest-api-specs
[NetAppFiles] fix default in volumeproperties (#15691)

* fix default in volumeproperties

* Update description

* Update description

Co-authored-by: Audunn Baldvinsson <[email protected]>

* version,CHANGELOG

* test

* bump node version (#20353)

* Remove old unused update changelog script (#20357)

Co-authored-by: Wes Haggard <[email protected]>

* Handle value types for results (#20358)

* Handle value types for results

* update test

* lint

* comprehension

* more precis

* fix test

* [rest] change text from a property to a method (#20290)

* [ServiceBus] update migration guide with message count info (#20360)

#20245

* Update CODEOWNERS (#20366)

* More Renaming in query (#20303)

* More Reanaming in query

* changelog

* commit 2

* some changes

* remove errror

* Update sdk/monitor/azure-monitor-query/azure/monitor/query/_models.py

* Apply suggestions from code review

Co-authored-by: Adam Ling (MSFT) <[email protected]>

* Update sdk/monitor/azure-monitor-query/CHANGELOG.md

Co-authored-by: Adam Ling (MSFT) <[email protected]>

* Fix Monitor opentelemetry exporter readme issues (#19038)

* [Key Vault] Add 7.3-preview support for administration (#20364)

* Update metadata values (#20365)

* Update metadata values

* distributed trace

* oops

* Update sdk/monitor/azure-monitor-query/CHANGELOG.md

* Apply suggestions from code review

* Bug fix for pipeline downloading incorrect package ver (#20294)

* Bug fix: pipeline to download correct package ver

* Update clean version

* Update clean version

* Cleanup

* Cleanup

* Cleanup

* Cleanup

* Comments added

* Testing

* Final-Version

* CertificateCredential supports PKCS12 certs (#16384)

* [rest] use azure json encoder for json input bodies (#20361)

* Document Pod Identity's special use of client_id (#20377)

* Consistency related changes (#20385)

* time stamp

* Rename AggragationType to MetricAggregationType

* Metric Class

* logs batch result

* MetricNamespaceClassification

* LogsTable + LogsTableColumn

* lint

* more lint

* Add Cloud Configuration section to Identity readme (#20373)

* keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (#20391)

* [AutoRelease] t2-costmanagement-2021-07-27-84467 (#19949)

* CodeGen from PR 15291 in Azure/azure-rest-api-specs
Updating Query filter description (#15291)

Co-authored-by: Jorge Chavez Nieto <[email protected]>

* version,CHANGELOG

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: Jorge Chavez Nieto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* [AutoRelease] t2-servicebus-2021-08-19-00756 (#20350)

* CodeGen from PR 14749 in Azure/azure-rest-api-specs
add apitestErrorCode doc (#14749)

* add apitestErrorCode doc

* add armRPC doc

* add roundTripInconsistentProperty doc

* small fix

* update

* update signalR armTemplate

* update yaml

* new file

* add testScenario with armTemplate

* update doc

* update readme.md

* update doc

* update NOTE section

* add signalRCreateOrUpdate example file

* udpate doc

* add generate test scenario section

* update doc

* add serviceFacbric test scenario file

* update managedClusters.yaml

* update generateABasicTestScenario.md

* update features doc

* add run api test gif

* version,CHANGELOG

* test

* Update test_cli_mgmt_servicebus_namespace.py

* Update test_queues.py

* Update test_queues.py

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <[email protected]>
Co-authored-by: Jiefeng Chen <[email protected]>

* [AutoRelease] t2-policyinsights-2021-08-23-78735 (#20381)

* CodeGen from PR 15165 in Azure/azure-rest-api-specs
[policyinsights] Fix next_link (#15165)

* fix next_link

* directive

* Update readme.nodejs.md

* js directvie

* Update readme.md

* supress other language

* Update readme.go.md

* swagger lint

* swagger lint

* swagger lint

* Update readme.md

* version,CHANGELOG

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <[email protected]>

* [AutoRelease] t2-datamigration-2021-08-19-04035 (#20349)

* CodeGen from PR 15259 in Azure/azure-rest-api-specs
Dev datamigration microsoft.data migration 2021 06 30 (#15259)

* Created new api version and refactoring changes (such as fixing new build restrictions)

* Adding breaking changes

* Adding location to the services update example

* Adding location for projects update and refactoring the task command

* Resolving tasks command ModelValidation test failure

* Resolving issue based on zhenglaizhang's recommendation

* Adding comma to resolve issue

Co-authored-by: Artem Pavlichenko <[email protected]>

* version,CHANGELOG

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: Artem Pavlichenko <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* Chain exceptions from LibsecretPersistence (#20380)

* [translation] fix poller.details (#20392)

* fixing docstring types for async client

* populate poller.details.id immediately

* pylint

* add bug fix to changelog

* improve begin_translation docstring (#20401)

* Update .docsettings.yml (#20402)

* Sync eng/common directory with azure-sdk-tools for PR 1918 (#20342)

* Stress test deployment script resiliency fixes

* Use PSModule-Helpers to install powershell-yaml

Co-authored-by: Ben Broderick Phillips <[email protected]>

* improve docs and samples for glossaries and custom models (#18587)

* update the readme

* update readme file

* added custom translation samples

* fix 'no-locale' thing in links

* update glossary docs

* update glossaries

* link to sample glossaries instead of writing code in readme

* update custom model sample linking

* remove relative linking in readme

* make subheadings in bold text to be more readable

* conform with 'Document Translation' naming

* disambiguate container sas url

* capitaliz Azure name

* remove misplaced period

* update samples -> custom model

* update async sample -> custom model

* remove localization from url

* update readme with new file types for glossaries

* adding sample glossaries -> xlf

* white space

* use simplified single input method

* update 'job' terminology

* update azure-core naming

* update glossary blob file reference name

* link to supported glossaries table

* remove locale from url

* [purview account] first release for azure-purview-account (#20335)

* purview account

* CI

* verion-tolerant

* endpoint order

* add test for collections

* Update CHANGELOG.md

* review

* update reamdme

* skip custom translation model samples (#20414)

* Address API view issues (#20407)

* logs client

* lc-2

* models changes

* more changes

* more changes

* more arch changes

* changelog

* tests

* lint

* fix tests

* timespan

* [translation] naming alignment (#20406)

* list_all_translation_statuses -> list_translation_statuses

* list_all_document_statuses -> list_document_statuses

* cancelled -> canceled, cancelling -> canceling

* FileFormat -> DocumentTranslationFileFormat

* update changelog

* make core tests offline (#19986)

* make core tests offline

* clean up

* use localhost instead of 127.0.0.1

* update

* update

* update

* Get rid of LogsBatchQueryResult (#20418)

* Get rid of LogsBatchQueryResult

* Update sdk/monitor/azure-monitor-query/README.md

* oops

* comments

* [AutoRelease] t2-iothub-2021-08-25-25696 (#20409)

* CodeGen from PR 15722 in Azure/azure-rest-api-specs
Removing readonly for isVerified property as it is no more readonly property (#15722)

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422)

* CodeGen from PR 15381 in Azure/azure-rest-api-specs
Update readme.md (#15381)

* version,CHANGELOG

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* Stip empty changelog sections before release (#20437)

Co-authored-by: Chidozie Ononiwu <[email protected]>

* Update question-answering readme links (#20439)

* ensure test principal creation succeeds properly (#20446)

Co-authored-by: scbedd <[email protected]>

* New dummy password in README (#20328)

* Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450)

* Bug fix: Storing .env file for bicep file at service dir

* Styling

Co-authored-by: Albert Cheng <[email protected]>

* [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423)

* CodeGen from PR 15458 in Azure/azure-rest-api-specs
Add rotation permission (#15458)

* Add rotation permission

* Update keys.json

Remove required from lifetimeActions

* Change to expiryTime

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* new recordings

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: Audunn Baldvinsson <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: iscai-msft <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Rakshith Bhyravabhotla <[email protected]>
Co-authored-by: swathipil <[email protected]>
Co-authored-by: McCoy Patiño <[email protected]>
Co-authored-by: Adam Ling (MSFT) <[email protected]>
Co-authored-by: Tong Xu (MSFT) <[email protected]>
Co-authored-by: ckairen <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Azure CLI Bot <[email protected]>
Co-authored-by: Jorge Chavez Nieto <[email protected]>
Co-authored-by: Zed Lei <[email protected]>
Co-authored-by: Jiefeng Chen <[email protected]>
Co-authored-by: Artem Pavlichenko <[email protected]>
Co-authored-by: Krista Pratico <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Mohamed Shaban <[email protected]>
Co-authored-by: msyyc <[email protected]>
Co-authored-by: Xiang Yan <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: annatisch <[email protected]>
Co-authored-by: Albert Cheng <[email protected]>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Sep 13, 2022
Review request for Microsoft.ContainerService to add version 2022-08-02-preview (Azure#20487)

* Adds base for updating Microsoft.ContainerService from version preview/2022-07-02-preview to version 2022-08-02-preview

* Updates readme

* Updates API version in new specs and examples

* sync changes from PR#19592 & PR#20145 (Azure#20402)

* update readme & remove fleets (Azure#20388)

* AKS agent pool properties add AgentPoolWindowsProfile and DisableOutboundNAT (Azure#20407)

* AKS agent pool properties add AgentPoolWindowsProfile and DisableOutboundNAT

* Change disableOutboundNAT to disableOutboundNat because of ARM format; Improve description.

* Improve description

* Added guardrails profile to specs (Azure#20171)

* added guardrails profile to specs

* linter fix

* added x-ms-enum

* added guardrails definitions for versions route

* linter fix, added custom word

* fix

* typo fix

* fix for example

* added object type

* added object type

* removed data field

* changed descriptions

* *

* add "Mariner" for AKS os sku (Azure#20420)

* add KubeProxyConfig to AKS NetworkProfile (Azure#20446)

* add KubeProxyConfig to AKS NetworkProfile

* remove extra comma, type: integer for *Seconds

* add custom words

* prettier

* follow camel case ARM guidance

* 2nd camel case standard

* feat: add rest api spec for ip-based lb (Azure#20392)

* fix LroLocationHeader (Azure#20491)

* fix ProvisioningStateValidation (Azure#20490)

* Removed guardrailsVersions route, added guardrails profice to MC properties (Azure#20625)

* removed guardrails-versions route, added guardrails profice to MC properties

* removed unsued file for guardrails versions, removed unused custom word

Co-authored-by: Shiqian Tao <[email protected]>
Co-authored-by: rsamigullin <[email protected]>
Co-authored-by: Ace Eldeib <[email protected]>
Co-authored-by: Matt Stam <[email protected]>
Co-authored-by: Qi Ni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants