Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translation] fix samples with renamed params #20063

Merged
merged 1 commit into from
Aug 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ async def sample_list_document_statuses_with_filters_async():
start = datetime(2021, 4, 12)
end = datetime(2021, 4, 14)
statuses = ["Cancelled", "Failed"]
order_by = ["createdDateTimeUtc desc"]
order_by = ["created_on desc"]
results_per_page = 2
skip = 3

Expand All @@ -60,8 +60,8 @@ async def sample_list_document_statuses_with_filters_async():
translation_id,
# filters
statuses=statuses,
translated_after=start,
translated_before=end,
created_after=start,
created_before=end,
# ordering
order_by=order_by,
# paging
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ async def sample_list_translations_with_filters_async():
start = datetime(2021, 4, 12)
end = datetime(2021, 4, 14)
statuses = ["Cancelled", "Failed"]
order_by = ["createdDateTimeUtc desc"]
order_by = ["created_on desc"]
results_per_page = 2
skip = 3

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,16 @@ def sample_list_document_statuses_with_filters():
start = datetime(2021, 4, 12)
end = datetime(2021, 4, 14)
statuses = ["Cancelled", "Failed"]
order_by = ["createdDateTimeUtc desc"]
order_by = ["created_on desc"]
results_per_page = 2
skip = 3

filtered_docs = client.list_all_document_statuses(
translation_id,
# filters
statuses=statuses,
translated_after=start,
translated_before=end,
created_after=start,
created_before=end,
# ordering
order_by=order_by,
# paging
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def sample_list_translations_with_filters():
start = datetime(2021, 4, 12)
end = datetime(2021, 4, 14)
statuses = ["Cancelled", "Failed"]
order_by = ["createdDateTimeUtc desc"]
order_by = ["created_on desc"]
results_per_page = 2
skip = 3

Expand Down