Remove responses and return a list #19872
Conversation
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -131,7 +131,7 @@ def query(self, workspace_id, query, duration=None, **kwargs): | |||
| process_error(e) | |||
|
|
|||
| def batch_query(self, queries, **kwargs): | |||
There was a problem hiding this comment.
Shouldn't it return a pageable object?
There was a problem hiding this comment.
no - service doesn't support paging
There was a problem hiding this comment.
I think our guideline is even service does not support page, we should wrap the return into pageable results?
@annatisch
There was a problem hiding this comment.
we talked to the architects and they were fine in this case with not supporting both paging and LRO
as service is not planning to ever support it on these endpoints
There was a problem hiding this comment.
i have created this issue for september milestone to follow up again #19942
| generated, request_order | ||
| ) | ||
| return order_results( | ||
| request_order, |
There was a problem hiding this comment.
what if the id in request_order does not exist in results?
There was a problem hiding this comment.
it will always exist - it's a 1:1 mapping
Review request for Microsoft.ContainerService to add version 2022-07-02-preview (Azure#20062) * Adds base for updating Microsoft.ContainerService from version preview/2022-06-02-preview to version 2022-07-02-preview * Updates readme * Updates API version in new specs and examples * update readmes (Azure#19872) * Add example of Azure KeyVault Secrets Provider Addon for 2022-07-02-preview (Azure#19874) * add example of kv secret provider addon * fix * fix lint * move ADH GA type to preview (Azure#19904) * move ADH GA type to preview * fix prettier check issue * add overlay vpa swagger (Azure#19936) * add overlay vpa objects * fix typo * address comments Co-authored-by: zhifanhui <[email protected]> * Swagger API for Operation Abort (Azure#19971) * Swagger API for Operation Abort * Swagger changes updates for Abort operation based on validations * Haitao/secured by perimeter0702 (Azure#19873) * add SecuredByPerimeter in publicNetworkAccess * update enum value descriptions * Add support for ImageCleaner on AKS (Azure#19916) * Add support for ImageCleaner on AKS * add more context in ImageCleaner description * add default for availableAgentPoolVersions (Azure#19902) * Add Azure Monitor Metrics (Prometheus) Profile (Azure#19965) * Add Azure Monitor Metrics (Prometheus) Profile * spelling error * restructure to names from rp * commit to rerun build * ksm metrics Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: huizhifan <[email protected]> Co-authored-by: zhifanhui <[email protected]> Co-authored-by: InduSridhar <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: jiashun0011 <[email protected]> Co-authored-by: bragi92 <[email protected]>
No description provided.