Add context manager API to azure.identity credentials #19746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mccoyp
reviewed
Jul 17, 2021
sdk/identity/azure-identity/azure/identity/aio/_credentials/app_service.py
Outdated
Show resolved
Hide resolved
mccoyp
approved these changes
Jul 19, 2021
chlowell
force-pushed
the
context-managers
branch
from
d8cb5fe
to
28d7d0c
Compare
Co-authored-by: McCoy Patiño <[email protected]>
chlowell
force-pushed
the
context-managers
branch
from
ec8370b
to
a572786
Compare
mccoyp
reviewed
Aug 11, 2021
sdk/identity/azure-identity/azure/identity/aio/_credentials/azure_arc.py
Outdated
Show resolved
Hide resolved
| @pytest.mark.parametrize("environ", ALL_ENVIRONMENTS) | ||
| def test_close(environ): | ||
| transport = mock.MagicMock() | ||
| with mock.patch.dict("os.environ", environ, clear=True): |
There was a problem hiding this comment.
Did you want to patch {Credential}.__module__ + ".os.environ" across the board, or just in async EnvironmentCredential tests?
There was a problem hiding this comment.
I would like to use more narrow patches everywhere. It doesn't work here because the inner credentials need to observe the same environment variables. Since broad patches don't impact our tests as currently run, I prefer using one here over baking more knowledge of the implementation into this test or testing the inner credentials separately.
Co-authored-by: McCoy Patiño <[email protected]>
mccoyp
approved these changes
Aug 11, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Aug 23, 2021
…into have_pipelines_support_rest * 'main' of https://github.com/Azure/azure-sdk-for-python: (108 commits) Enable API review approval check for Java spring packages (Azure#20311) [AutoRelease] t2-iothubprovisioningservices-2021-07-15-81882 (Azure#19816) Increment package version after release of azure-eventgrid (Azure#20204) Sync eng/common directory with azure-sdk-tools for PR 1909 (Azure#20298) Rename attrs is metrics (Azure#20236) [EventHubs] checkpointstoretable - skip tests until env vars configured (Azure#20289) Update to use timespan (Azure#20233) Prevent wildcard expansion in git sparse checkout add (Azure#20267) Fix typo and polish the key concepts (Azure#18407) Fix IOT Device Update readme issue (Azure#18752) Add context manager API to azure.identity credentials (Azure#19746) Add support for 'files' configuration (Azure#20272) Update main for 30-close.py (Azure#20287) [AutoRelease] t2-purview-2021-08-13-30358 (Azure#20260) add implementation for checkpointstoretable (Azure#19905) Fix resource clean-up script (Azure#20273) [Tables] Fix bug in update mode (Azure#20264) Add Rest Method checks to Prepare-Release (Azure#20275) Update release date (Azure#20270) Update the release date for ACS chat 1.1.0b1 (Azure#20277) ...
iscai-msft
pushed a commit
that referenced
this pull request
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18798