Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[textanalytics] APIView feedback #19473

Merged
merged 2 commits into from
Jun 25, 2021
Merged

[textanalytics] APIView feedback #19473

merged 2 commits into from
Jun 25, 2021

Conversation

kristapratico
Copy link
Member

Feedback to drop "Type" from the enums. Other languages don't seem to have the Type suffix from what I can see.

  • Removed HealthcareEntityRelationRoleType
  • Renamed HealthcareEntityRelationType to HealthcareEntityRelation
  • Renamed PiiEntityCategoryType to PiiEntityCategory
  • Renamed PiiEntityDomainType to PiiEntityDomain
  • Fixed type hints and docstrings for begin_analyze_healthcare_entities and begin_analyze_actions to include DocumentError in the heterogeneous output

@kristapratico kristapratico requested a review from iscai-msft June 25, 2021 00:56
@kristapratico kristapratico self-assigned this Jun 25, 2021
@kristapratico kristapratico requested a review from abhahn as a code owner June 25, 2021 00:56
iscai-msft
iscai-msft approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @kristapratico !!!

@iscai-msft iscai-msft merged commit 8cb17c0 into Azure:main Jun 25, 2021
iscai-msft added a commit that referenced this pull request Jun 25, 2021
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
6b23aa2 
…into rest_layer

* 'main' of https://github.com/Azure/azure-sdk-for-python:
  [core] add testserver (#19153)
  autorest repo needs to checkout from master still (#19499)
  [Event Hubs] [Service Bus] add logging snippet to readme (#19171)
  apiview / anna feedback (#19473)
  Make IMDS unavailability easier to debug (#19423)
  [Resourcehealth] first release (#19484)
  CAE support for azure-mgmt-core (#19365)
  Update references from master to main (#19471)
  Update links from master to main
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Jul 16, 2021
@kristapratico @rakshith91
apiview / anna feedback (Azure#19473)
050c22e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iscai-msft iscai-msft iscai-msft approved these changes

@abhahn abhahn Awaiting requested review from abhahn

Assignees

@kristapratico kristapratico

Labels
Cognitive - Text Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristapratico @iscai-msft