Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional run black for formatting #19329

Merged
8 commits merged into from
Jun 29, 2021
Merged

optional run black for formatting #19329

8 commits merged into from
Jun 29, 2021

Conversation

seankane-msft
Copy link
Member

No description provided.

@seankane-msft seankane-msft requested a review from a team as a code owner June 18, 2021 16:36
@seankane-msft seankane-msft linked an issue Jun 18, 2021 that may be closed by this pull request
@seankane-msft seankane-msft added EngSys This issue is impacting the engineering system. and removed Container Registry labels Jun 24, 2021
long_description = f.read()

setup(
name=PACKAGE_NAME,
version=version,
description='Microsoft Azure {} Client Library for Python'.format(PACKAGE_PPRINT_NAME),

description="Microsoft Azure {} Client Library for Python".format(PACKAGE_PPRINT_NAME),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ran black on this boyo :)

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :shipit: :shipit: :shipit: :shipit:

@scbedd
Copy link
Member

scbedd commented Jun 28, 2021

@seankane-msft I was entirely fine with the changes you made to the template folder 👍

@ghost
Copy link

ghost commented Jun 29, 2021

Hello @seankane-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 3d2c0b5 into main Jun 29, 2021
@ghost ghost deleted the eng-black branch June 29, 2021 17:34
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Jul 16, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EngSys] opt-in check for running black and failing on a diff
2 participants