Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Key Vault] Custom polling method for admin backup client #19204

Merged
merged 27 commits into from
Jun 16, 2021
Merged

[Key Vault] Custom polling method for admin backup client #19204

merged 27 commits into from
Jun 16, 2021

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Jun 10, 2021 •
edited
Loading

This adds a custom polling method for KeyVaultBackupClient so that rehydrating pollers can be done with (encoded) operation status URLs instead of full PipelineResponses.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jun 10, 2021
@mccoyp mccoyp requested a review from chlowell June 10, 2021 17:31
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@mccoyp mccoyp marked this pull request as ready for review June 15, 2021 00:36
@mccoyp mccoyp requested a review from schaabs as a code owner June 15, 2021 00:36
@mccoyp mccoyp requested a review from chlowell June 15, 2021 00:37
@mccoyp
Copy link
Member Author

mccoyp commented Jun 15, 2021

/check-enforcer reset

@mccoyp
Copy link
Member Author

mccoyp commented Jun 15, 2021

/azp run python - keyvault - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

chlowell
chlowell reviewed Jun 15, 2021
View reviewed changes
sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/polling.py Outdated Show resolved Hide resolved
...vault/azure-keyvault-administration/azure/keyvault/administration/_internal/async_polling.py Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/polling.py Outdated Show resolved Hide resolved
...eyvault-administration/tests/recordings/test_backup_client.test_full_backup_and_restore.yaml Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-administration/tests/test_examples_administration.py Show resolved Hide resolved
sdk/keyvault/azure-keyvault-administration/tests/test_examples_administration.py Outdated Show resolved Hide resolved
@mccoyp mccoyp requested a review from chlowell June 15, 2021 23:13
@mccoyp mccoyp requested a review from chlowell June 16, 2021 01:23
@mccoyp mccoyp requested a review from chlowell June 16, 2021 18:11
@mccoyp mccoyp requested a review from chlowell June 16, 2021 23:31
chlowell
chlowell approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work you put in to this! :shipit:

@mccoyp mccoyp merged commit 380445f into Azure:master Jun 16, 2021
@mccoyp mccoyp deleted the admin-polling branch June 16, 2021 23:42
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jun 17, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
fb692df 
…into get_testserver_working

* 'master' of https://github.com/Azure/azure-sdk-for-python: (55 commits)
  [AppConfig] mypy fixes (Azure#18858)
  [translation] renames (Azure#19285)
  [Key Vault] Update metadata for release (Azure#19286)
  [AppConfig] enable samples (Azure#18857)
  KeyVaultBackupOperation -> KeyVaultBackupResult (Azure#19284)
  renaming (Azure#19280)
  [Key Vault] Custom polling method for admin backup client (Azure#19204)
  [textanalytics] add ARM template + run samples in CI (Azure#19270)
  removed example from description (Azure#18781)
  [Key Vault] Update READMEs with RBAC information (Azure#19275)
  Sync eng/common directory with azure-sdk-tools for PR 1688 (Azure#19272)
  update all ubuntu vmImage to 20.04 (Azure#19227)
  add base class for feedback (Azure#19265)
  Enable tests for integration samples (Azure#18531)
  docs: fix a few simple typos (Azure#19127)
  Increment package version after release of azure-eventgrid (Azure#19197)
  Increment package version after release of azure-monitor-query (Azure#19208)
  earliest versions of communication identity tests are set up improperly. skip 1.0.0 in regression testing (Azure#19258)
  Run mypy in azure-keyvault-administration CI (Azure#19246)
  [text analytics] change return type of analyze actions to list of list (Azure#18994)
  ...
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Jun 4, 2022
CodeGen from PR 19204 in Azure/azure-rest-api-specs
8fb39e3 
change URL format for hostName description (Azure#19204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell approved these changes

@schaabs schaabs Awaiting requested review from schaabs

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccoyp @chlowell