-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Communication]: Cleaned up ACS samples #18656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Communication
label
May 12, 2021
/azp run python - communication - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
lsundaralingam
requested review from
ankitarorabit,
memontic-ms and
a team
as code owners
May 12, 2021 18:13
jbeauregardb
approved these changes
May 12, 2021
beltr0n
approved these changes
May 12, 2021
beltr0n
requested changes
May 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're in clean up, I don't think ACS account is the right term. It's part of the ACS resource in your Azure account. maybe change it to ACS resource?
/azp run python - communication - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
beltr0n
approved these changes
May 12, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
May 25, 2022
[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 (Azure#18656) * Add comment to Change state parameters * fix error * fix error * fix * fix * fix error * fix validations * add example for operation list command * fix example * fix example * fix * fix * delete json file * add origin parameter to operation defenition * fix * fix * fix * delete unneccesary files * revert packege-lock.json file changes Co-authored-by: Khaled Abo Asbe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.