Increase dependency #18500
Merged
Increase dependency #18500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
rakshith91
commented
May 4, 2021
sdk/core/azure-core-tracing-opentelemetry/azure/core/tracing/ext/opentelemetry_span/__init__.py
Outdated
Show resolved
Hide resolved
…xt/opentelemetry_span/__init__.py
lmazuel
reviewed
May 4, 2021
| @@ -221,6 +221,7 @@ def set_http_attributes(self, request, response=None): | |||
| :param response: The response received by the server. Is None if no response received. | |||
| :type response: ~azure.core.pipeline.transport.HttpResponse or ~azure.core.pipeline.transport.AsyncHttpResponse | |||
| """ | |||
| self.kind = SpanKind.CLIENT | |||
There was a problem hiding this comment.
You're changing the behavior of the mixin, why?
There was a problem hiding this comment.
Discussed offline, this is revert of:
https://github.com/Azure/azure-sdk-for-python/pull/17785/files#diff-363cd4d434eb6553b982b1473cd363d4afa4b14c36acec10f060a874f63cbe09L224
There was a problem hiding this comment.
actually - i already added the kind in the distributed tracing policy and removed it from here previously in this PR
#17785
- duplicating this line here ensures backward compatibility with previosuly released versions of azure-core-tracing-opentelemetry
rakshith91
commented
May 4, 2021
sdk/core/azure-core-tracing-opentelemetry/azure/core/tracing/ext/opentelemetry_span/__init__.py
Outdated
Show resolved
Hide resolved
…xt/opentelemetry_span/__init__.py
rakshith91
commented
May 4, 2021
rakshith91
commented
May 4, 2021
|
running the regression tests here https://dev.azure.com/azure-sdk/internal/_build/results?buildId=875505&view=results |
lmazuel
approved these changes
May 4, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 5, 2021
…into azure_purview_catalog * 'master' of https://github.com/Azure/azure-sdk-for-python: (109 commits) [Tables] Adds support for AzureNamedKeyCredential (Azure#18456) [Tables] delete_entity takes an entity instead of row and partition key (Azure#18269) [Tables] Removed TableEntity attribute wrapper (Azure#18489) [EventHub&ServiceBus] Bump uAMQP dependency (Azure#17942) [ServiceBus] add keyword override support to update_ methods in mgmt module (Azure#18210) Add compatibility switch to disable CAE (Azure#18148) Service Bus Named Key Credential (Azure#18471) Change to use dynamic resource connection string for chat tests and identity samples (Azure#18502) Increase dependency (Azure#18500) show detailed error (Azure#18229) prerelease (Azure#18507) [Container Registry] addressing issues (Azure#18486) update per_call_policies & per_retry_policies (Azure#18406) Eh named key (Azure#18292) [Tables] Updating EntityProperty (Azure#18177) [Service Bus] fix async auth test (Azure#18499) [communication] Live Testing - Introduce CloudConfig into test.yml (Azure#18469) Release azure-servicefabric 8.0 (Azure#18488) [Communication]: Updated test_search_available_phone_numbers_with_invalid_country_code async test to be consistent with sync test (Azure#18466) [Container Registry] DeleteRepositoryResult Changed (Azure#18443) ...
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
May 17, 2022
rebranding api docs from asc to mdfc (Azure#18500) * Copy solutions files from 2015-06-01-preview * update API version * update readme * Add required to ExternalSecuritySolution * add new swagger files * fix errors1 * fix2 * fix 3 * fix 4 * fix4 * fix4 * fix conflict * fix conflict2 * fix conflict4 * fix conflict 6 * fix conflict 7 * ttt * rrr * aaa * bbb * fix 10 * Prettier check * update readme * fix reference error * fix comment * fix conflict * fic conflict2 * fix conflict3 * fix conflict4 * remove files * delete externalSecuritySolutions * add assessments.json * fix readme.md * Fix validation errors 1 * Fix validation errors 2 * merge * Fix validation errors 3 * Fix validation errors 4 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 6 * Fix validation errors 4 * Fix validation errors 7 * Fix validation errors 8 * Fix validation errors 9 * Fix validation errors 10 * fix validation errors 11 * fix validation errors 11 * ix validation errors 12 * ix validation errors 13 * fix validation errors 14 * Fix validation errors 15 * Fix validation errors 16 * run prettier * Defining the APIs for the new NSP resource * test * SecuritySolution test * 2 * org * 1 * Rebranding effort * Update SecuritySolutions.json * Delete readme.md * ASC to MDC - rebranding * 1 * merge3 * update5 * update readme * update6 * update 6 * fix securitySolution * Create SecuritySolutions.json Co-authored-by: Arik Riklin <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.