Post Process Event Names Script #18419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakshith91
requested review from
lmazuel,
swathipil and
yunhaoling
as code owners
ghost
added
the
lmazuel
reviewed
May 4, 2021
| try: | ||
| event_name = re.findall("Microsoft.[a-zA-Z]+.[a-zA-Z]+", event[1].__doc__)[0] | ||
| except: | ||
| print(event[0]) |
There was a problem hiding this comment.
We should be more explicit here that we weren't able to generate the mapping and sys.exit(1) at least to be sure any automation that would run this script would be stopped and blocked.
rakshith91
commented
May 4, 2021
sdk/eventgrid/azure-eventgrid/swagger/postprocess_eventnames.py
Outdated
Show resolved
Hide resolved
|
/azp run python - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xiangyan99
reviewed
May 5, 2021
| @@ -0,0 +1,164 @@ | |||
| AcsChatMemberAddedToThreadWithUserEventName = ( | |||
There was a problem hiding this comment.
Why there is a swagger folder?
There was a problem hiding this comment.
just to add this sdk/eventgrid/azure-eventgrid/swagger/postprocess_eventnames.py file - we have an issue to hook it into the swagger readme itself -but for now, it exists here
also, removed the _eventmap.py file
xiangyan99
reviewed
May 5, 2021
| class_name = event[0].replace("Data", "Name") | ||
| try: | ||
| event_name = re.findall("Microsoft.[a-zA-Z]+.[a-zA-Z]+", event[1].__doc__)[0] | ||
| except: |
There was a problem hiding this comment.
Do we want to catch all types exceptions here?
There was a problem hiding this comment.
yes - since this script is to autogenerate the evenname mappings, we dont want to let anything slip by
xiangyan99
reviewed
May 5, 2021
| event_name = re.findall("Microsoft.[a-zA-Z]+.[a-zA-Z]+", event[1].__doc__)[0] | ||
| except: | ||
| # these two are just superclasses and are known exceptions. | ||
| if event[0] not in ('ContainerRegistryArtifactEventData', 'ContainerRegistryEventData'): |
There was a problem hiding this comment.
Is it possible event is not an array?
There was a problem hiding this comment.
event is always a tuple
xiangyan99
approved these changes
May 5, 2021
|
/azp run python - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 5, 2021
…into azure_purview_catalog * 'master' of https://github.com/Azure/azure-sdk-for-python: ignore analysis for swagger readmes (Azure#18520) [purview] add azure-purview-nspkg (Azure#18518) [AppConfiguration] Appconfig consistency (Azure#18493) [Container Registry] Improved samples (Azure#18263) [Container Registry] renamings (Azure#18492) [ServiceBus] internal code rename and sample readme update (Azure#18516) [EventHub] update link in sample readme (Azure#18517) Post Process Event Names Script (Azure#18419) [Tables] use etag from entity if match condition is given (Azure#18271) adding operation-location to headers that are scrubbed (Azure#18514)
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 6, 2021
…into azure_purview_scanning * 'master' of https://github.com/Azure/azure-sdk-for-python: (550 commits) del useless files (Azure#18528) delete existing useless files for trafficmanager (Azure#18525) Define new replacer to replace keys in recording (Azure#18294) [purview] add purview nspkg to ci (Azure#18523) ignore analysis for swagger readmes (Azure#18520) [purview] add azure-purview-nspkg (Azure#18518) [AppConfiguration] Appconfig consistency (Azure#18493) [Container Registry] Improved samples (Azure#18263) [Container Registry] renamings (Azure#18492) [ServiceBus] internal code rename and sample readme update (Azure#18516) [EventHub] update link in sample readme (Azure#18517) Post Process Event Names Script (Azure#18419) [Tables] use etag from entity if match condition is given (Azure#18271) adding operation-location to headers that are scrubbed (Azure#18514) [Tables] Adds support for AzureNamedKeyCredential (Azure#18456) [Tables] delete_entity takes an entity instead of row and partition key (Azure#18269) [Tables] Removed TableEntity attribute wrapper (Azure#18489) [EventHub&ServiceBus] Bump uAMQP dependency (Azure#17942) [ServiceBus] add keyword override support to update_ methods in mgmt module (Azure#18210) Add compatibility switch to disable CAE (Azure#18148) ...
scbedd
reviewed
May 12, 2021
| WebSlotSwapWithPreviewStartedEventName = 'Microsoft.Web.SlotSwapWithPreviewStarted' | ||
|
|
||
| # these names below are for backward compat only - refrain from using them. | ||
| AcsChatMemberAddedToThreadWithUserEventName = 'Microsoft.Communication.ChatMemberAddedToThreadWithUser' |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Mar 29, 2022
[DataFactory] Fix Expression mode for SqlServerStoredProcedureActivity (Azure#18419) * update * update * fix Co-authored-by: xiaojwan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18235
Fixes #18365