Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up PR Triggers #18186

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Apr 20, 2021

To reduce random build spam from tools/ and eng/ changes.

…e, given that there is a direct dependency relationship, but we don't need to include tools/eng outside of the core pipeline
@scbedd scbedd requested a review from mitchdenny as a code owner April 20, 2021 23:21
@scbedd scbedd requested a review from seankane-msft April 20, 2021 23:24
@scbedd
Copy link
Member Author

scbedd commented Apr 20, 2021

@seankane-msft reducing build spam on anything other than core changes. Leaving core triggering on eng/ and tools/ changes.

Copy link
Member

@seankane-msft seankane-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question. Will we be able to test pipeline fixes on libraries still? Or does this just reduce the number of libraries that will trigger on eng/tools changes?

@scbedd
Copy link
Member Author

scbedd commented Apr 20, 2021

Both, unfortunately. This is to reduce build spam from our eng/common changes. It's hitting the build pools pretty hard. We will still trigger core build on tools/eng changes though.

@scbedd scbedd merged commit 6809acd into Azure:master Apr 21, 2021
@scbedd scbedd deleted the hotfix/cleanup-build-triggers branch April 21, 2021 00:08
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Apr 22, 2021
…into azure_purview_catalog

* 'master' of https://github.com/Azure/azure-sdk-for-python: (205 commits)
  update FormField docstring (Azure#18226)
  [Event Hubs] combine conn str parsing logic (Azure#18059)
  [Blob]Edit Test for Single Thread Substream Retry (Azure#18206)
  maintenance changelog config (Azure#18216)
  Privated hierarchy traversal and fixed encryption algorithm (Azure#18212)
  Remove duplicate calls to bypass-local-dns.yml (Azure#18180)
  Patch changelog (Azure#18188)
  enable polling by default (Azure#18184)
  [Communication]: Added identity exception tests (Azure#18191)
  version (Azure#18202)
  [AutoRelease] t2-maintenance-2021-04-20-69227 (Azure#18166)
  Updated identity samples (Azure#18189)
  Sync eng/common directory with azure-sdk-tools for PR 1565 (Azure#18155)
  Clean Up PR Triggers (Azure#18186)
  [Tables] on a 413 throw a RequestEntity Too Large Error (Azure#18181)
  Add environment.yml to unify conda versioning (Azure#18141)
  [Fix]Add retry for streaming download (Azure#18164)
  Sync eng/common directory with azure-sdk-tools for PR 1558 (Azure#18178)
  Stop filtering projects by ci.yml files (Azure#18174)
  [Communication] - SDK - Added contributing file (Azure#18018)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants