[Communication]: Added exception to begin_update_phone_number_capabilities #18025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lsundaralingam
changed the title
lsundaralingam
requested review from
ankitarorabit,
memontic-ms,
turalf and
a team
as code owners
minnieliu
reviewed
Apr 14, 2021
| phone_number, | ||
| calling=calling, | ||
| sms=sms, | ||
| **kwargs | ||
| ) | ||
|
|
||
| result_properties = poller.result().additional_properties | ||
| if 'status' in result_properties and result_properties['status'] == 'failed': |
There was a problem hiding this comment.
Is this check case sensitive?
There was a problem hiding this comment.
Yes, this check is case sensitive.
There was a problem hiding this comment.
Discussed this offline. The status value isn't always lower case, so this check should handle that.
jbeauregardb
approved these changes
Apr 14, 2021
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
beltr0n
approved these changes
Apr 14, 2021
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Mar 7, 2022
Dev sentinel 2022 01 01 preview (Azure#18025) * Adds base for updating Microsoft.SecurityInsights from version preview/2021-10-01-preview to version 2022-01-01-preview * Updates readme * Updates API version in new specs and examples * SourceControl API 2022-01-01-preview version - adding new attribute to SourceControl model (Azure#17849) * SourceControl 2022-01-01-preview version change * fix validation error * prettified * prettified Co-authored-by: debjyoti11 <[email protected]> * New metadata API (Azure#17942) * metadata changes * addressed changes * updated enum kind * updated values as well Co-authored-by: Roey Ben Chaim <[email protected]> * added new enum to kind (Azure#17994) Co-authored-by: Roey Ben Chaim <[email protected]> * Add flag to rotate webhook secret (Azure#17989) Co-authored-by: debjyoti11 <[email protected]> * Align definitions with stable version (Azure#17931) * Align definitions with stable version * align scheduled rule and template properties with stable * Note: We are creating a new api-version with this change. Watchlists.json 2022-01-01-preview parameter name changes (Azure#17848) * changed source to sourceType and watchlistAlias to alias * Update CreateWatchlistAndWatchlistItems.json * Update CreateWatchlistItem.json * Update DeleteWatchlist.json * Update DeleteWatchlistItem.json * Update GetWatchlistByAlias.json * Update GetWatchlistItemById.json * Update GetWatchlistItems.json * Update GetWatchlistByAlias.json * added missing params to match stable version * Revert "added missing params to match stable version" This reverts commit a30a709613f94266d0eaba6495c92be43221a282. Reverting by 1 commit * refreshing pipeline * reverting lint diff change * attempting to fix RemovedPath breaking changes * Revert "attempting to fix RemovedPath breaking changes" This reverts commit 2f96ee3c050fde4c166bf730b0a1b5faff07cfc1. reverting attempt at correcting breaking changes. cannot match preview to stable without breaking everything. * adding back source type for backwards compatibility, added response descriptions, corrected PR comments * adding missing bracket * ran npm run prettier-fix to correct style issues * resolving model/definition errors * Revert "resolving model/definition errors" This reverts commit fd67a4f813d923965cefad50999010820446a107. Reverting prettier changes made to other branches * Revert "ran npm run prettier-fix to correct style issues" This reverts commit 3055791e00e956fff3a62e24d8313dde96daa00c. * update * Update DeleteWatchlist.json * Update Watchlists.json * Update DeleteWatchlist.json * Update DeleteWatchlist.json * Update DeleteWatchlist.json * Update DeleteWatchlist.json * Update DeleteWatchlist.json * Update DeleteWatchlist.json * fixing styling issues on Delete example * Update DeleteWatchlist.json * Update DeleteWatchlist.json * ran npm run prettier on DeleteWatchlist.json * Update Watchlists.json * reverting alias to watchlistAlias Co-authored-by: Hassan Chawiche <[email protected]> * Rename system to AutoAssigned (Azure#18061) * Rename system to AutoAssigned * Add example to list operations * Update API version in NRT examples * Execute validation tools and fix results (Azure#17733) * Execute validation tools and fic results * Prettyfieir GetIoTById.json * Watchlists.json-2022-01-01-preview-parameterNameChanges (reverted PR reference for files changed -> https://github.com/Azure/azure-rest-api-specs/pull/17848/files) (Azure#18085) * changed source to sourceType and watchlistAlias to alias * Update CreateWatchlistAndWatchlistItems.json * Update CreateWatchlistItem.json * Update DeleteWatchlist.json * Update DeleteWatchlistItem.json * Update GetWatchlistByAlias.json * Update GetWatchlistItemById.json * Update GetWatchlistItems.json * Update GetWatchlistByAlias.json * added missing params to match stable version * Revert "added missing params to match stable version" This reverts commit a30a709613f94266d0eaba6495c92be43221a282. Reverting by 1 commit * refreshing pipeline * reverting lint diff change * attempting to fix RemovedPath breaking changes * Revert "attempting to fix RemovedPath breaking changes" This reverts commit 2f96ee3c050fde4c166bf730b0a1b5faff07cfc1. reverting attempt at correcting breaking changes. cannot match preview to stable without breaking everything. * adding back source type for backwards compatibility, added response descriptions, corrected PR comments * adding missing bracket * ran npm run prettier-fix to correct style issues * resolving model/definition errors * Revert "resolving model/definition errors" This reverts commit fd67a4f813d923965cefad50999010820446a107. Reverting prettier changes made to other branches * Revert "ran npm run prettier-fix to correct style issues" This reverts commit 3055791e00e956fff3a62e24d8313dde96daa00c. * update * Update DeleteWatchlist.json * Update Watchlists.json * Update DeleteWatchlist.json * Update DeleteWatchlist.json * Update DeleteWatchlist.json * Update DeleteWatchlist.json * Update DeleteWatchlist.json * Update DeleteWatchlist.json * fixing styling issues on Delete example * Update DeleteWatchlist.json * Update DeleteWatchlist.json * ran npm run prettier on DeleteWatchlist.json * Update Watchlists.json * reverting alias to watchlistAlias * fixing type version * Update Watchlists.json * Update DeleteWatchlist.json * fixing commas Co-authored-by: Hassan Chawiche <[email protected]> Co-authored-by: Usman Hasan <[email protected]> * Done (Azure#17843) Co-authored-by: Roy Reinhorn <[email protected]> * AutomationRules 2022-01-01-preview: Add constraints (Azure#18099) * add contraints (alinged with the latest stable version) Co-authored-by: debroy <[email protected]> Co-authored-by: debjyoti11 <[email protected]> Co-authored-by: RoeyBC <[email protected]> Co-authored-by: Roey Ben Chaim <[email protected]> Co-authored-by: Laith Hisham <[email protected]> Co-authored-by: ushasan <[email protected]> Co-authored-by: Hassan Chawiche <[email protected]> Co-authored-by: shschwar <[email protected]> Co-authored-by: Usman Hasan <[email protected]> Co-authored-by: royrein <[email protected]> Co-authored-by: Roy Reinhorn <[email protected]> Co-authored-by: dosegal <[email protected]> Co-authored-by: Arthur Ning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address the case when the service returns a response with the status code 200 and an error in the body.