Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tables] Cosmos workaround for Merge/Update #17888

Merged
13 commits merged into from
Apr 8, 2021

Conversation

seankane-msft
Copy link
Member

@seankane-msft seankane-msft commented Apr 7, 2021

Closes #13844

@seankane-msft seankane-msft requested a review from annatisch April 7, 2021 23:05
@seankane-msft seankane-msft self-assigned this Apr 7, 2021
Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - thanks for this!

assert transaction_result.get_entity('batch_all_operations_together-2') is not None
assert transaction_result.get_entity('batch_all_operations_together-3') is not None
assert transaction_result.get_entity('batch_all_operations_together-4') is not None
assert transaction_result.get_entity('batch_all_operations_together-5') is not None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should rename this method - it's a bit too close to client.get_entity.
I'll have a think about this one :)

Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)
Maybe add a note to the changelog?

@ghost
Copy link

ghost commented Apr 8, 2021

Hello @seankane-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit cb464b2 into Azure:master Apr 8, 2021
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Apr 9, 2021
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Apr 13, 2021
benbp pushed a commit to benbp/azure-sdk-for-python that referenced this pull request Apr 19, 2021
@seankane-msft seankane-msft deleted the tables-cosmos-retry branch May 18, 2021 16:12
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 8, 2022
Adding Lots by Customer (Azure#17888)

* Adding Lots by Customer

* Prettier fix

* Fixing Semantic

* Fixing Semantic

* Fixing Semantic

* Update consumption.json

* Fixing PR comments

* Deleting properties not allowed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tables] Merge operation fails with a Cosmos endpoint
2 participants