Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc translator] adding tests #17511

Merged
merged 44 commits into from
Mar 31, 2021
Merged

[doc translator] adding tests #17511

merged 44 commits into from
Mar 31, 2021

Conversation

mshaban-msft
Copy link
Contributor

solves #17041

kristapratico
kristapratico reviewed Mar 24, 2021
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay tests! :) just wondering, are test recordings like this being generated for you locally when you run the tests?

sdk/documenttranslation/azure-ai-documenttranslation/tests/artifact_test.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/test_list_status.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/test_list_status.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/test_list_status.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/testcase.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/test_translation.py Outdated Show resolved Hide resolved
kristapratico
kristapratico reviewed Mar 26, 2021
View reviewed changes
sdk/documenttranslation/azure-ai-documenttranslation/tests/test_all_document_statuses.py Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/test_all_document_statuses.py Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/testcase.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/testcase.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/testcase.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/test_list_submitted_jobs.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/test_list_submitted_jobs.py Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/test_list_submitted_jobs.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/test_list_submitted_jobs.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/test_list_submitted_jobs.py Outdated Show resolved Hide resolved
@mshaban-msft mshaban-msft force-pushed the v-moshaban/17041/adding_tests branch from 6005043 to f2b0275 Compare March 30, 2021 00:36
kristapratico
kristapratico approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I love what you did with the validation functions. Let's merge it when it's green. 🚀

sdk/documenttranslation/azure-ai-documenttranslation/tests/testcase.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/testcase.py Outdated Show resolved Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/tests/testcase.py Outdated Show resolved Hide resolved
@mshaban-msft mshaban-msft force-pushed the v-moshaban/17041/adding_tests branch from e2592c9 to 5ccace2 Compare March 30, 2021 17:42
MIDDLEEAST\v-moshaban added 17 commits March 31, 2021 03:23
MIDDLEEAST\v-moshaban added 25 commits March 31, 2021 03:23
[test] cancel job
96b9182
[tests] refactor helper functions
df8bab4
[tests] added async tests
d6e3bf1
[tests] skip some tests (functionality is hidden for now)
9e2844b
[tests][pr reviews] correct silly mistake -> calling function with ar…
c75debf 
…gument self!
[test] lazy fix -> sample trsnaltion jobs -> wait until done for stat…
789010d 
…us to be succeeded
[test] some bugs
d13c578
[tests] fix gettting first item if async iterator
011ebe9
[tests] fix cancelled job status propagation
f2398c5
[tests] fix iterator len issue in sync client
f53e925
[tests] fix 'self' keyword used unnecessarily
9b4fc39
[test] fix get length of async iterator
756e719
[tests] update tests after actually running them
8ad8f56
[tests] sync client updates
eb9c479
[tests] add sync client test recordings
eaf8abb
[tests] fixed async client tests
fa7f0a9
[tests] adding async recordings
d16498f
[tests] adding conftest.py for py2 async tests
74fbaa0
[tests] update recordings
0d985c8
[tests] pr reviews
7fbf545
[tests] created AsyncDocumentTranslationTest for python 3
a428819
[tests] setting polling interval to zero when running recorded tests
7eac34b
[tests] updated polling interval for wait_until_done method in client
3888faf
[tests] updating recorded tests
472a51b
[tests] updated records -> downgrade azure core bug
9c9b768
@mshaban-msft mshaban-msft force-pushed the v-moshaban/17041/adding_tests branch from dc9cefa to 9c9b768 Compare March 31, 2021 01:46
@kristapratico kristapratico merged commit b285461 into Azure:master Mar 31, 2021
@kristapratico kristapratico mentioned this pull request Mar 31, 2021
Closed
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 21, 2022
CodeGen from PR 17511 in Azure/azure-rest-api-specs
85ff52d 
add x-ms-enum to trafficmanager (Azure#17511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

@mayurid mayurid Awaiting requested review from mayurid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshaban-msft @kristapratico