Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NetworkTraceLoggingPolicy show the auth token in plain text #17424

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Make NetworkTraceLoggingPolicy show the auth token in plain text #17424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdk/core/azure-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## 1.12.1 (Unreleased)

### Bug fixes

- Make NetworkTraceLoggingPolicy show the auth token in plain text. #14191

## 1.12.0 (2021-03-08)

Expand Down
2 changes: 0 additions & 2 deletions sdk/core/azure-core/azure/core/pipeline/policies/_universal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,6 @@ def on_request(self, request):
_LOGGER.debug("Request method: %r", http_request.method)
_LOGGER.debug("Request headers:")
for header, value in http_request.headers.items():
if header.lower() == 'authorization':
value = '*****'
annatisch marked this conversation as resolved.
Show resolved Hide resolved
_LOGGER.debug(" %r: %r", header, value)
_LOGGER.debug("Request body:")

Expand Down