Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Communication] - Phone Numbers - Added async samples #17314

Merged
merged 4 commits into from
Mar 16, 2021
Merged

[Communication] - Phone Numbers - Added async samples #17314

merged 4 commits into from
Mar 16, 2021

Conversation

jbeauregardb
Copy link
Contributor

No description provided.

@jbeauregardb jbeauregardb changed the title More samples [Communication] - Phone Numbers - Added async samples Mar 12, 2021
@ghost ghost added the Communication label Mar 12, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

ankitarorabit
ankitarorabit reviewed Mar 16, 2021
View reviewed changes
...nication/azure-communication-phonenumbers/samples/update_phone_number_capabilities_sample.py Outdated
)
phone_numbers_client = PhoneNumbersClient.from_connection_string(connection_str)

def update_phone_number_capabilities():
poller = phone_numbers_client.begin_update_phone_number_capabilities(
"+18335260208",
PhoneNumberCapabilityType.OUTBOUND,
"+18332408820",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here as well

lsundaralingam
lsundaralingam approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@lsundaralingam lsundaralingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a few minor comments.

...cation/azure-communication-phonenumbers/samples/list_purchased_phone_numbers_async_sample.py Outdated
python list_purchased_phone_numbers_sample.py
Set the environment variables with your own values before running the sample:
1) AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING - The connection string including your endpoint and
access key of your Azure Communication Service"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Shouldn't the triple quotes be on a new line?

@jbeauregardb jbeauregardb force-pushed the more-samples branch 2 times, most recently from 6e40e43 to 733c77c Compare March 16, 2021 19:05
@jbeauregardb jbeauregardb merged commit b6cea5c into Azure:master Mar 16, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Feb 7, 2022
@ShaniFelig @roherzbe
@igalshapira @iKlotz @msklotz @royrein @lilyanc02 @viskumar-microsoft
CodeGen from PR 17494 in Azure/azure-rest-api-specs
97e44c1 
Dev sentinel 2021 10 01 preview (Azure#17494)

* Adds base for updating Microsoft.SecurityInsights from version preview/2021-09-01-preview to version 2021-10-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add IoT data connector (Azure#17086)

* add Iot data connector

* fix kind in getIotById

* add deleted files

* add missing newlines

* fix newlines

* Revert "Add IoT data connector (Azure#17086)" (Azure#17170)

This reverts commit a11dd79ea1fb12c9b9d673fed2de91cc0098adbf.

* Adding providerIncidentUrl & techniques to IncidentAdditionalData (Azure#17173)

* Adding providerIncidentUrl to Incident

* Adding techniques to incident

* Dev sentinel 2021 10 01 preview (Azure#17314)

* Bookmarks 2021-10-01-preview

* prettier

* definitions

* rename

Co-authored-by: Igal Shapira <[email protected]>

* Data connectors 2021 10 01 preview office connectors added (Azure#17193)

* Project and PowerBI specs added.

* Space removed

* File with a wrong name removed

* More changer added

* Example files with inconsistent naming removed

* dataConnectors json updated

* Ref fixed

* Prettier applied

Co-authored-by: Ido Klotz <[email protected]>

* AutomationRules preview 2021_10_01 (Azure#17325)

* h

* first

* examples

* prettier

* path

* fixes

* prettier

* examples

* Z

* Z

* responses

* fix

* fixes

* fix

* prettier

* PR Fixes

* PR Fixes

* PR Fixes

* fix

* fix

* fix

* fix

* Last

* PR Fixes

* Last

* tryFix

* tryFix

* incidentTypes

* fix

Co-authored-by: Roy Reinhorn <[email protected]>

* Add MITRE support to alert rules models (Azure#17198)

* Update alert rules models with tactics and techniques

* Add attack tactics new enum values

* Update alert rules models examples

* Fix techniques type

* Update files with prettier

* Insert validations fixes

* Fix validations

* Fixes in alert rules models

* Fix alert rules models and examples

* adding changes to alert rules json

* Revert "adding changes to alert rules json"

This reverts commit 603490e300c76dee48550a11d0dee8fe5c824a2e.

* Adding fusion v2 ui api documentation

* some fixes

* adding prettier fixes

* removing unwanted property

* updating the readonly properties

Co-authored-by: Lilyan Cohen <[email protected]>
Co-authored-by: Vishal Kumar <[email protected]>

* ErrorResponse changed to CloudError (Azure#17477)

Co-authored-by: Ido Klotz <[email protected]>

* Done (Azure#17488)

Co-authored-by: Roy Reinhorn <[email protected]>

* Adding tenantId (Azure#17533)

Co-authored-by: Ido Klotz <[email protected]>

* Done (Azure#17556)

Co-authored-by: Roy Reinhorn <[email protected]>

* Fix LindDiff and SemanticValidation (Azure#17584)

Co-authored-by: ShaniFelig <[email protected]>
Co-authored-by: roherzbe <[email protected]>
Co-authored-by: Igal <[email protected]>
Co-authored-by: Igal Shapira <[email protected]>
Co-authored-by: Ido Klotz <[email protected]>
Co-authored-by: Ido Klotz <[email protected]>
Co-authored-by: royrein <[email protected]>
Co-authored-by: Roy Reinhorn <[email protected]>
Co-authored-by: lilyanc02 <[email protected]>
Co-authored-by: Lilyan Cohen <[email protected]>
Co-authored-by: Vishal Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsundaralingam lsundaralingam lsundaralingam approved these changes

@ankitarorabit ankitarorabit ankitarorabit approved these changes

@memontic-ms memontic-ms Awaiting requested review from memontic-ms

@turalf turalf Awaiting requested review from turalf

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbeauregardb @lsundaralingam @ankitarorabit @jorge-beauregard