Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-common] Provide link to migration documentation for unsupported client factories #17173

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sdk/core/azure-common/azure/common/client_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,15 @@ def get_client_from_json_dict(client_class, config_dict, **kwargs):
)

parameters.update(kwargs)
return _instantiate_client(client_class, **parameters)
try:
return _instantiate_client(client_class, **parameters)
except TypeError:
docs_url = "aka.ms/{route}" #TODO: provide real link to migration guide
raise TypeError(
"{} does not support initialization with azure-common factory methods. See {} for more details.".format(
client_class.__name__, docs_url
)
)

def get_client_from_auth_file(client_class, auth_path=None, **kwargs):
"""Return a SDK client initialized with auth file.
Expand Down