Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventGrid] Improve docs #16986

Merged
merged 6 commits into from
Mar 1, 2021
Merged

Conversation

rakshith91
Copy link
Contributor

@rakshith91 rakshith91 commented Mar 1, 2021

Fixes #15978
Fixes #14747
Fixes #15940

@rakshith91 rakshith91 mentioned this pull request Mar 1, 2021
@rakshith91 rakshith91 changed the title Eg update readme [EventGrid] Improve docs Mar 1, 2021
Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few small comments about general flow. Big fan of the sample snippets in the readme :)

sdk/eventgrid/azure-eventgrid/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/README.md Outdated Show resolved Hide resolved
@rakshith91 rakshith91 merged commit 36f2003 into Azure:master Mar 1, 2021
@rakshith91 rakshith91 deleted the eg_update_readme branch March 1, 2021 21:53
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 1, 2021
…into correct_healthcare

* 'master' of https://github.com/Azure/azure-sdk-for-python: (30 commits)
  [EventGrid] Improve docs (Azure#16986)
  Fixed delete_blob method signature (Azure#16983)
  Fixed Content-MD5 serialization and typing (Azure#16987)
  [eventgrid] Black formatting and tests suite (Azure#16989)
  Appconfig perf test (Azure#16809)
  adds support for milliseconds on datetime objects (Azure#16847)
  [ServiceBus] Improve AMQP Error handling (Azure#16427)
  T2 resource 2021 02 26 (Azure#16961)
  T2 servicefabricmanagedclusters 2021 02 26 (Azure#16958)
  Update Prepare-Release script (Azure#16976)
  the previous filter was erroneously filtering out real files. (Azure#16978)
  Update azure-core minimum version (Azure#16968)
  update documention in depends section of eng_sys_checks.md (Azure#16967)
  version (Azure#16959)
  T2 web 2021 02 24 (Azure#16901)
  Change test pipeline to run in eastus2 (Azure#16950)
  Adding azure-devtools to mr-auth dev_requirements (Azure#16953)
  Add perf tests for eventgrid (Azure#16949)
  temp fix for canary tests (Azure#16945)
  Update get_package_properties to also return path to setup.py (Azure#16946)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Dec 9, 2021
Fix in JobSupportedAction (Azure#16986)

* Fixing s360 correctness items

* Fixing spell check and prettier

* Updating latest version in readme

* Fix in jobsupportedAction
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Dec 9, 2021
Fix in JobSupportedAction (Azure#16986)

* Fixing s360 correctness items

* Fixing spell check and prettier

* Updating latest version in readme

* Fix in jobsupportedAction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants