-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appconfig perf test #16809
Merged
Merged
Appconfig perf test #16809
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
sdk/appconfiguration/azure-appconfiguration/dev_requirements.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
sdk/appconfiguration/azure-appconfiguration/tests/perfstress_tests/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# App config Performance Tests | ||
|
||
In order to run the performance tests, the `azure-devtools` package must be installed. This is done as part of the `dev_requirements`. | ||
Start be creating a new virtual environment for your perf tests. This will need to be a Python 3 environment, preferably >=3.7. | ||
|
||
### Setup for test resources | ||
|
||
These tests will run against a pre-configured application configuration service. The following environment variable will need to be set for the tests to access the live resources: | ||
``` | ||
AZURE_APP_CONFIG_CONNECTION_STRING=<app config connection string> | ||
``` | ||
|
||
### Setup for perf test runs | ||
|
||
```cmd | ||
(env) ~/azure-appconfiguration> pip install -r dev_requirements.txt | ||
(env) ~/azure-appconfiguration> pip install -e . | ||
``` | ||
|
||
## Test commands | ||
|
||
When `azure-devtools` is installed, you will have access to the `perfstress` command line tool, which will scan the current module for runable perf tests. Only a specific test can be run at a time (i.e. there is no "run all" feature). | ||
|
||
```cmd | ||
(env) ~/azure-appconfiguration> cd tests | ||
(env) ~/azure-appconfiguration/tests> perfstress | ||
``` | ||
Using the `perfstress` command alone will list the available perf tests found. | ||
|
||
### Common perf command line options | ||
These options are available for all perf tests: | ||
- `--duration=10` Number of seconds to run as many operations (the "run" function) as possible. Default is 10. | ||
- `--iterations=1` Number of test iterations to run. Default is 1. | ||
- `--parallel=1` Number of tests to run in parallel. Default is 1. | ||
- `--warm-up=5` Number of seconds to spend warming up the connection before measuring begins. Default is 5. | ||
- `--sync` Whether to run the tests in sync or async. Default is False (async). This flag must be used for Storage legacy tests, which do not support async. | ||
- `--no-cleanup` Whether to keep newly created resources after test run. Default is False (resources will be deleted). | ||
|
||
## Example command | ||
```cmd | ||
(env) ~/azure-appconfiguration/tests> perfstress GetTest | ||
``` |
Empty file.
38 changes: 38 additions & 0 deletions
38
sdk/appconfiguration/azure-appconfiguration/tests/perfstress_tests/get.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# -------------------------------------------------------------------------------------------- | ||
# Copyright (c) Microsoft Corporation. All rights reserved. | ||
# Licensed under the MIT License. See License.txt in the project root for license information. | ||
# -------------------------------------------------------------------------------------------- | ||
|
||
import os | ||
|
||
from azure_devtools.perfstress_tests import PerfStressTest | ||
|
||
from azure.appconfiguration import ConfigurationSetting, AzureAppConfigurationClient as SyncAppConfigClient | ||
from azure.appconfiguration.aio import AzureAppConfigurationClient as AsyncAppConfigClient | ||
|
||
|
||
class GetTest(PerfStressTest): | ||
def __init__(self, arguments): | ||
super().__init__(arguments) | ||
connection_string = self.get_from_env("AZURE_APP_CONFIG_CONNECTION_STRING") | ||
self.key = "KEY" | ||
self.service_client = SyncAppConfigClient.from_connection_string(connection_string=connection_string) | ||
self.async_service_client = AsyncAppConfigClient.from_connection_string(connection_string=connection_string) | ||
|
||
async def global_setup(self): | ||
await super().global_setup() | ||
kv = ConfigurationSetting( | ||
key=self.key, | ||
value="VALUE", | ||
) | ||
await self.async_service_client.set_configuration_setting(kv) | ||
|
||
async def close(self): | ||
# await self.async_service_client.close() | ||
await super().close() | ||
|
||
def run_sync(self): | ||
self.service_client.get_configuration_setting(key=self.key) | ||
|
||
async def run_async(self): | ||
await self.async_service_client.get_configuration_setting(key=self.key) |
42 changes: 42 additions & 0 deletions
42
sdk/appconfiguration/azure-appconfiguration/tests/perfstress_tests/set.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# -------------------------------------------------------------------------------------------- | ||
# Copyright (c) Microsoft Corporation. All rights reserved. | ||
# Licensed under the MIT License. See License.txt in the project root for license information. | ||
# -------------------------------------------------------------------------------------------- | ||
|
||
import os | ||
import uuid | ||
|
||
from azure_devtools.perfstress_tests import PerfStressTest | ||
|
||
from azure.appconfiguration import ConfigurationSetting, AzureAppConfigurationClient as SyncAppConfigClient | ||
from azure.appconfiguration.aio import AzureAppConfigurationClient as AsyncAppConfigClient | ||
|
||
|
||
class SetTest(PerfStressTest): | ||
service_client = None | ||
async_service_client = None | ||
|
||
def __init__(self, arguments): | ||
super().__init__(arguments) | ||
connection_string = self.get_from_env("AZURE_APP_CONFIG_CONNECTION_STRING") | ||
self.key = "KEY" | ||
self.service_client = SyncAppConfigClient.from_connection_string(connection_string=connection_string) | ||
self.async_service_client = AsyncAppConfigClient.from_connection_string(connection_string=connection_string) | ||
|
||
async def close(self): | ||
# await self.async_service_client.close() | ||
await super().close() | ||
|
||
def run_sync(self): | ||
kv = ConfigurationSetting( | ||
key=self.key, | ||
value="VALUE" + str(uuid.uuid4()), | ||
) | ||
self.service_client.set_configuration_setting(kv) | ||
|
||
async def run_async(self): | ||
kv = ConfigurationSetting( | ||
key=self.key, | ||
value="VALUE" + str(uuid.uuid4()), | ||
) | ||
await self.async_service_client.set_configuration_setting(kv) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: We could move the
str(uuid.uuid4())
into the constructor to avoid generating it in the perf test