[Key Vault] Test certificates library against a shared vault #16792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
added
KeyVault
Client
mccoyp
force-pushed
the
sharedvault-certs
branch
from
87210cd
to
d14fffc
Compare
chlowell
approved these changes
Feb 18, 2021
| @@ -4,17 +4,20 @@ | |||
| # ------------------------------------ | |||
| import asyncio | |||
| import functools | |||
| import pytest | |||
There was a problem hiding this comment.
Grouping pytest with standard library imports contravenes the PEP 8 style we usually enforce with pylint (but not on test files so I'm nitpicking here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15434.
This implements the same preparer changes from #16474 in the certificates library. This also updates
tests.ymlto deploy ARM templates for certificates tests, and tweaks the test resource cleanup script to purge pending certificates (so that deleted certificates that were cancelled during creation can actually get purged).